From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged
Date: Wed, 29 Sep 2010 17:03:05 -0400 [thread overview]
Message-ID: <20100929210305.GA28782@denix.org> (raw)
In-Reply-To: <1285792798-6529-1-git-send-email-fransmeulenbroeks@gmail.com>
On Wed, Sep 29, 2010 at 10:39:58PM +0200, Frans Meulenbroeks wrote:
> copy the files directly from the work area to staging. That way
> there are no unpackaged files in image/ so no NOTE messages.
> Additional advantage is that it is faster as we save the copy to the image dir.
>
> See also http://thread.gmane.org/gmane.comp.handhelds.openembedded/37487
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> Acked-by: Roman I Khimov <khimov@altell.ru>
> Tested-by: Petr ?tetiar <ynezz@true.cz>
> Acked-by: Eric B?nard <eric@eukrea.com>
Acked-by: Denys Dmytriyenko <denis@denix.org>
> ---
>
> This is the formal patch, following up the discussion mentioned above
> It really works like a charm. Kernel build time is greatly reduced.
>
> If there are no objections, and since there are already 2 acks,
> I will push tomorrow my evening (20 hrs or so after posting)
> Feel free to add additional acks.
>
> Frans
>
> classes/kernel.bbclass | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/classes/kernel.bbclass b/classes/kernel.bbclass
> index 5f8bc8a..cfb4ad8 100644
> --- a/classes/kernel.bbclass
> +++ b/classes/kernel.bbclass
> @@ -121,7 +121,12 @@ kernel_do_install() {
> oe_runmake SUBDIRS="scripts/genksyms"
> fi
>
> - kerneldir=${D}/kernel/
> +
> +}
> +
> +sysroot_stage_all_append() {
> +
> + kerneldir=${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
>
> if [ -e include/asm ] ; then
> # This link is generated only in kernel before 2.6.33-rc1, don't stage it for newer kernels
> @@ -200,11 +205,6 @@ kernel_do_install() {
> cp -fR scripts $kerneldir/
> }
>
> -sysroot_stage_all_append() {
> - sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
> - cp -fpPR ${D}/kernel/.config ${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
> -}
> -
> kernel_do_configure() {
> yes '' | oe_runmake oldconfig
> if [ ! -z "${INITRAMFS_IMAGE}" ]; then
> --
> 1.6.4.2
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2010-09-29 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 20:39 [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged Frans Meulenbroeks
2010-09-29 21:03 ` Denys Dmytriyenko [this message]
2010-09-29 21:35 ` Paul Menzel
2010-09-30 6:30 ` Frans Meulenbroeks
2010-09-30 9:45 ` Paul Menzel
2010-10-04 14:27 ` Frans Meulenbroeks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929210305.GA28782@denix.org \
--to=denis@denix.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox