Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] amend.bbclass: handle PACKAGE_ARCH change in an	amend.inc
Date: Thu, 18 Nov 2010 13:03:46 -0500	[thread overview]
Message-ID: <20101118180346.GA18493@denix.org> (raw)
In-Reply-To: <1290002140-17255-1-git-send-email-eric@eukrea.com>

On Wed, Nov 17, 2010 at 02:55:40PM +0100, Eric B??nard wrote:
> * setting PACKAGE_ARCH = "${MACHINE_ARCH}" in and amend.inc actually
> leads to a packaga with the correct machine arch but the
> work/stage/stamp dirs are not correct because MULTIMACH_ARCH is not
> updated after amend.inc is parsed.
> 
> * this patch updates MULTIMACH_ARCH if PACKAGE_ARCH is changed in
> amend.inc
> 
> Signed-off-by: Eric B??nard <eric@eukrea.com>

Thanks! We have faced this issue before.

Acked-by: Denys Dmytriyenko <denis@denix.org>

> ---
>  classes/amend.bbclass |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/classes/amend.bbclass b/classes/amend.bbclass
> index a03de64..da60611 100644
> --- a/classes/amend.bbclass
> +++ b/classes/amend.bbclass
> @@ -42,5 +42,11 @@ python () {
>              depends = set()
>          depends |= set(newdata)
>      d.setVar("__depends", depends)
> +
> +    mach_arch = bb.data.getVar('MACHINE_ARCH', d, 1)
> +    pkg_arch = bb.data.getVar('PACKAGE_ARCH', d, 1)
> +    multi_arch = bb.data.getVar('MULTIMACH_ARCH', d, 1)
> +    if pkg_arch and pkg_arch == mach_arch and pkg_arch != multi_arch:
> +        multi_arch = pkg_arch
> +        bb.data.setVar('MULTIMACH_ARCH', multi_arch, d)
>  }
> -- 
> 1.7.2.3
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



  reply	other threads:[~2010-11-18 18:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 13:55 [PATCH] amend.bbclass: handle PACKAGE_ARCH change in an amend.inc Eric Bénard
2010-11-18 18:03 ` Denys Dmytriyenko [this message]
2010-11-18 18:11   ` Eric Bénard
2010-11-18 18:46     ` Paul Menzel
2010-11-21 15:19     ` [PATCH] " Eric Bénard
2010-11-21 16:28       ` Khem Raj
2010-11-21 17:53       ` Chris Larson
2010-11-21 18:46         ` Eric Bénard
2010-11-21 19:42         ` Eric Bénard
2010-11-21 23:16           ` Chris Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118180346.GA18493@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox