Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH resend] package.bbclass: call PACKAGESTRIPFUNCS before populate_packages
Date: Wed, 15 Dec 2010 21:27:52 -0800	[thread overview]
Message-ID: <20101216052752.GC18068@gmail.com> (raw)
In-Reply-To: <4D0614C6.5060105@opendreambox.org>

On (13/12/10 13:42), Andreas Oberritter wrote:
> Ping
> 
> On 12/08/2010 02:00 PM, Andreas Oberritter wrote:
> >   Introduce run_strip_funcs() to call the functions in
> >   PACKAGESTRIPFUNCS and place it before populate_packages().
> > 
> >   This allows users of do_split_packages() to package the .debug
> >   directories, which get created by do_runstrip().
> > 
> >   do_split_packages() is usually prepended to populate_packages().
> > 
> > Signed-off-by: Andreas Oberritter <obi@opendreambox.org>

looks ok to me. I thought .debug are automatically picked into -debug
packages 
In what cases will this help ?

> > ---
> >  classes/package.bbclass |   12 +++++++-----
> >  1 files changed, 7 insertions(+), 5 deletions(-)
> > 
> > diff --git a/classes/package.bbclass b/classes/package.bbclass
> > index 2769595..678ffa9 100644
> > --- a/classes/package.bbclass
> > +++ b/classes/package.bbclass
> > @@ -367,6 +367,12 @@ python perform_packagecopy () {
> >  	os.system('cp -pPR %s/. %s/' % (installdest, pkgcopy))
> >  }
> >  
> > +python run_strip_funcs() {
> > +	if (bb.data.getVar('PACKAGE_STRIP', d, True) != 'no'):
> > +		for f in (bb.data.getVar('PACKAGESTRIPFUNCS', d, True) or '').split():
> > +			bb.build.exec_func(f, d)
> > +}
> > +
> >  python populate_packages () {
> >  	import glob, errno, re,os
> >  
> > @@ -391,11 +397,6 @@ python populate_packages () {
> >  		else:
> >  			package_list.append(pkg)
> >  
> > -
> > -	if (bb.data.getVar('PACKAGE_STRIP', d, True) != 'no'):
> > -		for f in (bb.data.getVar('PACKAGESTRIPFUNCS', d, True) or '').split():
> > -			bb.build.exec_func(f, d)
> > -
> >  	pkgdest = bb.data.getVar('PKGDEST', d, True)
> >  	os.system('rm -rf %s' % pkgdest)
> >  
> > @@ -1011,6 +1012,7 @@ PACKAGE_PREPROCESS_FUNCS ?= ""
> >  PACKAGEFUNCS ?= "perform_packagecopy \
> >                  ${PACKAGE_PREPROCESS_FUNCS} \
> >  		package_do_split_locales \
> > +		run_strip_funcs \
> >  		populate_packages \
> >  		package_do_shlibs \
> >  		package_do_pkgconfig \
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



  reply	other threads:[~2010-12-16  5:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 13:00 [PATCH resend] package.bbclass: call PACKAGESTRIPFUNCS before populate_packages Andreas Oberritter
2010-12-13 12:42 ` Andreas Oberritter
2010-12-16  5:27   ` Khem Raj [this message]
2010-12-16 12:04     ` Andreas Oberritter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101216052752.GC18068@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox