Re: [PATCH 2/5] perl 5.10.1: fix Time::HiRes cross-compilation

[Roman I Khimov <roman@khimov.ru>]

[-- Attachment #1: Type: Text/Plain, Size: 1368 bytes --]

В сообщении от Суббота 25 декабря 2010 22:57:43 автор Khem Raj написал:
> On 12/25/2010 10:25 AM, Roman I Khimov wrote:
> > В сообщении от Суббота 25 декабря 2010 20:30:49 автор Khem Raj написал:
> >> On 12/25/2010 2:48 AM, Roman I Khimov wrote:
> >>> We can't do 'run' check, so let's hope compile check is enough.
> >>> Fixes
> >>>
> >>> Time::HiRes::nanosleep(): unimplemented in this platform
> >>>
> >>> error.
> >>>
> >>> Signed-off-by: Roman I Khimov<khimov@altell.ru>
> >>
> >> is it possible to cache the vars instead? that will be better to keep
> >> list of variables that are not runchecked
> >
> > Well, glancing at code another time, it probably could be solved via
> > d_nanosleep in Config.sh. I think it's safe to assume that all of our
> > targets implement nanosleep().
> 
> hmmm, I would be skeptical on the assumption 

If you're skeptical about it, then I think it's better to leave the automatic 
test as it is now (patched). Because the run part of it comes from very rare 
corner-cases, there is a comment in test program:

    ret = nanosleep(&ts1, &ts2); /* E.g. in AIX nanosleep() fails and sets 
errno to ENOSYS. */

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]