From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] insane.bbclass: fix the check for bad RPATH
Date: Fri, 11 Feb 2011 16:38:30 -0800 [thread overview]
Message-ID: <20110212003830.GJ1010@gmail.com> (raw)
In-Reply-To: <1296716421-19240-1-git-send-email-denis@denix.org>
On (03/02/11 02:00), Denys Dmytriyenko wrote:
> * Variable 'sane' is boolean, so adding to it breaks the error condition
> * Fixes previous commit 6aa31074 ported from Yocto
>
> Signed-off-by: Denys Dmytriyenko <denis@denix.org>
Acked-by: Khem Raj <raj.khem@gmail.com>
> ---
> classes/insane.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/classes/insane.bbclass b/classes/insane.bbclass
> index 50752b5..a846832 100644
> --- a/classes/insane.bbclass
> +++ b/classes/insane.bbclass
> @@ -174,7 +174,7 @@ def package_qa_check_rpath(file,name,d, elf):
> for dir in bad_dirs:
> if dir in line:
> error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
> - sane = sane + package_qa_handle_error(1, error_msg, name, file, d)
> + sane = package_qa_handle_error(1, error_msg, name, file, d)
>
> return sane
>
> --
> 1.7.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2011-02-12 0:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 7:00 [PATCH] insane.bbclass: fix the check for bad RPATH Denys Dmytriyenko
2011-02-12 0:38 ` Khem Raj [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-13 15:50 Andreas Mueller
2011-02-13 20:33 ` Khem Raj
2011-02-13 22:36 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212003830.GJ1010@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox