Re: [PATCH 1/1] matrix-tui: Update to arago toolchain

[Denys Dmytriyenko <denis@denix.org>]

On Wed, Jun 22, 2011 at 05:17:48PM -0500, Maupin, Chase wrote:
> > > @@ -28,7 +21,7 @@ S = "${WORKDIR}/trunk"
> > >  #INITSCRIPT_PARAMS = "defaults 99"
> > >
> > >  do_configure() {
> > > -	sed -i -e 's:PATH=${LINUX_DEVKIT_PATH}/arm-none-linux-
> > gnueabi:PATH ?= ${LINUX_DEVKIT_PATH}/arm-none-linux-gnueabi:'
> > makefile.init
> > > +	sed -i -e 's:PATH=${LINUX_DEVKIT_PATH}/arm-arago-linux-
> > gnueabi:PATH ?= ${LINUX_DEVKIT_PATH}/arm-arago-linux-gnueabi:'
> > makefile.init
> > 
> > I don't think this is needed. The whole point of that sed magic I put
> > in
> > there, is to make assignments of TUI_INCLUDE_PATH, XML_INCLUDE_PATH and
> > TUI_LIB_PATH conditionally, so they can be overwritten below in the
> > do_compile() task...
> 
> The makefile defaults have been changed to use arm-arago-linux-gnueabi 
> instead of the arm-none-linux-gnueabi.  If you want these values to still be 
> optionally assigned then you would still need these changes right?
> 
> Now perhaps a better way to do this is change the makefile.init to use the 
> ?= optional assignment so that you don't need to do this sed magic.  Would 
> that also work?

That would be great, thanks!


> > >  	sed -i -e 's|LIBS :=|LIBS := ${LDFLAGS} |' Release/objects.mk

Maybe you can add this one in the default Makefile too? :) Less hacking in the 
recipe.

-- 
Denys