Re: [meta-handheld v2] linux-kexecboot: use kernel_conf_variable like linux.inc does and respect CMDLINE_DEBUG

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]

On Mon, Nov 21, 2011 at 11:43:46AM +0100, Andrea Adami wrote:
> On Sun, Nov 20, 2011 at 12:26 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> Martin,
> 
> I agree for the use kernel_conf_variable but I'm unsure about CMDLINE_DEBUG.
> In fact, I hardcoded it purposedly with commit 8929166 with the
> following reasons:
> 
> * Being a second-stage bootloader we don't expect any output on screen.
> * Adding 'debug' as commandline arg is pointless because
> * linux-kexecboot is compiled without debug and printk in order
> * to minimize the size.
> * Full debug implies not only editing the commandline (e.g. earlyprintk)
> * but re-enabling full debug options in the defconfigs

I had some issues with 3.2.0-rc2 when used as linux-kexecboot, that's
why I've added this, but later found out that it's really a bit
incomplete, that's why I have followup patch for this:
https://gitorious.org/shr/meta-handheld/commit/6bc710615b587fc0bfd8fc4372cad0de5599dd82?format=patch

But with latest SRCREV it works again, so in theory I don't need it, but
still it would be usefull to have easy way to debug even this stage
(maybe you still remember older kernel version where it worked fine 
as 3rd stage and failed to boot as 2nd stage..).

BTW: here is upgrade to 3.2.0-rc2 with those changes to
linux-kexecboot.inc applied
https://gitorious.org/shr/meta-handheld/commit/27ca3d24353a5473f4f1aade00ba7a52b667e28c?format=patch

(be aware that I do rebase that branch sometimes so if those commits are
not valid anymore just look at last few commits in that branch).

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]