From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Tsx6F-0003eO-L2 for openembedded-devel@lists.openembedded.org; Wed, 09 Jan 2013 15:57:53 +0100 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id r09EgcX5003852 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Wed, 9 Jan 2013 06:42:39 -0800 (PST) Received: from yow-jmacdona-d1.ottawa.wrs.com (128.224.146.66) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server (TLS) id 14.2.318.4; Wed, 9 Jan 2013 06:42:39 -0800 Received: from yow-jmacdona-l1 (yow-jmacdona-d2.wrs.com [128.224.146.166]) by yow-jmacdona-d1.ottawa.wrs.com (Postfix) with ESMTP id AA5C87FCE for ; Wed, 9 Jan 2013 09:41:01 -0500 (EST) Received: by yow-jmacdona-l1 (Postfix, from userid 1000) id E3D0E24157; Wed, 9 Jan 2013 09:42:37 -0500 (EST) Date: Wed, 9 Jan 2013 09:42:37 -0500 From: Joe MacDonald To: Message-ID: <20130109144237.GB5259@windriver.com> References: <1356124984-19927-1-git-send-email-morgan.little@windriver.com> <20130109142224.GP3722@jama.palm1.palmone.com> MIME-Version: 1.0 In-Reply-To: <20130109142224.GP3722@jama.palm1.palmone.com> X-URL: http://github.com/joeythesaint/joe-s-common-environment/tree/master X-Configuration: git://github.com/joeythesaint/joe-s-common-environment.git X-Editor: Vim-703 http://www.vim.org User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [meta-networking][PATCH] traceroute: Remove bashisms X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2013 14:58:00 -0000 X-Groupsio-MsgNum: 42602 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mojUlQ0s9EVzWg2t" Content-Disposition: inline --mojUlQ0s9EVzWg2t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [Re: [oe] [meta-networking][PATCH] traceroute: Remove bashisms] On 13.01.09= (Wed 15:22) Martin Jansa wrote: > On Fri, Dec 21, 2012 at 10:02:28PM +0000, Little, Morgan wrote: > > On 12/21/2012 04:37 PM, Martin Jansa wrote: > > > On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little > > > wrote: > > >> Signed-off-by: Morgan Little > > >> --- > > >> meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6= ++---- > > >> 1 file changed, 2 insertions(+), 4 deletions(-) > > >> > > >> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2= =2E0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> index 719d9fb..d855c67 100644 > > >> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb > > >> @@ -32,10 +32,8 @@ do_install() { > > >> > > >> install -d ${D}${mandir} > > >> install -p -m644 ${PN}/${PN}.8 ${D}${mandir} > > >> - pushd ${D}${mandir} > > >> - ln -s ${PN}.8 ${PN}6.8 > > >> - ln -s ${PN}.8 tcptraceroute.8 > > >> - popd > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8 > > >> + ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8 > > > > > > Thanks for quick reply and fix, but I think this should be: > > >> + ln -s ${PN}.8 ${D}${mandir}/${PN}6.8 > > >> + ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8 > > > > > > ${D} path won't be valid on target and missing slash after mandir > > It looks like it should be. Thank you for noticing that. > > > > > > And is there something referencing those man pages with different > > > name? Or why are those symlinks provided? > > I provided them because I was basing the do_install step off of the .sp= ec file the Fedora uses in their RPM file. It does a similar symlink step. = I believe that is can be removed. >=20 > ping :) I think this belongs to me to finish up now. I plan to remove them. I've kept the thread in my inbox so hopefully I can cover all the comments on it. --=20 -Joe MacDonald. :wq --mojUlQ0s9EVzWg2t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlDtgd0ACgkQPN8S4W6ZZneMkQCfdUUdunTWQJSQI/N5SdSKZt+B 4ZsAn3ClsbbPf9dl1Edqj1uBnF7HuxQE =0rUQ -----END PGP SIGNATURE----- --mojUlQ0s9EVzWg2t--