From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: gst-ffmpeg configure-fix patch and yasm
Date: Thu, 11 Apr 2013 16:18:28 +0200 [thread overview]
Message-ID: <20130411141828.GJ2477@jama> (raw)
In-Reply-To: <20130403050703.GB10679@jama.dyndns-home.com>
[-- Attachment #1: Type: text/plain, Size: 3159 bytes --]
On Wed, Apr 03, 2013 at 07:07:03AM +0200, Martin Jansa wrote:
> On Sat, Mar 30, 2013 at 09:30:51PM +0100, dv wrote:
> > On 03/30/13 17:40, Otavio Salvador wrote:
> > > On Sat, Mar 30, 2013 at 12:00 PM, dv <dv@pseudoterminal.org> wrote:
> > >> Hello,
> > >>
> > >> I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13:
> > >>
> > >> + if test "x$disable_yasm" != "xyes"; then
> > >> + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm"
> > >> + fi
> > >>
> > >> Shouldn't the test be: if test "x$disable_yasm" = "xyes" ?
> > >> To me, it seems as if this code adds --disable-yasm if disable_yasm is not
> > >> set to "yes", which is the complete opposite of the intended behavior.
> > >>
> > >> Or am I missing some detail about shell script code here?
> > > I think you are right here. Maybe you could provide a fix for it?
> > > --
> > > Otavio Salvador O.S. Systems
> > > E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
> > > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
> > >
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >
> > No problem. Patch for the patch attached :)
>
> This patch is for oe-core, it needs to be resend to
> openembedded-core@lists.openembedded.org
Tom's patch was applied in oe-core
http://git.openembedded.org/openembedded-core/commit/?id=da9515621134c26e54f43b96cdad0c6e6c5876bf
>
> > From 4624e30adb13ad361f886eeda4272a7235bedd61 Mon Sep 17 00:00:00 2001
> > From: Carlos Rafael Giani <dv@pseudoterminal.org>
> > Date: Sat, 30 Mar 2013 21:29:22 +0100
> > Subject: [PATCH] gst-ffmpeg: configure-fix patch used wrong test
> >
> > Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> > ---
> > .../recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch
> > index 81029ca..2bb124b 100644
> > --- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch
> > +++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch
> > @@ -11,7 +11,7 @@ diff -r f2f8f74c6e30 configure.ac
> > --enable-gpl"
> > fi
> >
> > -+ if test "x$disable_yasm" != "xyes"; then
> > ++ if test "x$disable_yasm" = "xyes"; then
> > + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm"
> > + fi
> > +
> > --
> > 1.8.2
> >
>
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2013-04-11 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 15:00 gst-ffmpeg configure-fix patch and yasm dv
2013-03-30 16:40 ` Otavio Salvador
2013-03-30 20:30 ` dv
2013-03-30 22:10 ` Otavio Salvador
2013-04-03 5:07 ` Martin Jansa
2013-04-11 14:18 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411141828.GJ2477@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox