Re: [meta-gnome 2/2] libnotify: update to 0.7.5 and drop libnotify3

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 5627 bytes --]

On Thu, Apr 18, 2013 at 02:45:47PM +0200, Andreas Müller wrote:
> On Thu, Apr 18, 2013 at 1:24 PM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
> > On Thu, Apr 18, 2013 at 1:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> On Thu, Apr 18, 2013 at 11:53:45AM +0200, Andreas Müller wrote:
> >>> On Thu, Apr 18, 2013 at 10:22 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >>> > On Thu, Apr 18, 2013 at 08:58:24AM +0200, Andreas Müller wrote:
> >>> >> On Wed, Apr 17, 2013 at 4:01 PM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> >>> >> > -----BEGIN PGP SIGNED MESSAGE-----
> >>> >> > Hash: SHA1
> >>> >> >
> >>> >> > Op 17-04-13 15:49, Andreas Müller schreef:
> >>> >> >> removing tests drops dependencies on gtk
> >>> >> >>
> >>> >> >> Tested by:
> >>> >> >>
> >>> >> >> * building nautilus3 (the only recipe found depending on libnotify3) *
> >>> >> >> running xfce-based image and checked notififations
> >>> >> >
> >>> >> > The problem with libnotify was (is?) that it removed some API that GNOME 2.x
> >>> >> > depends on and later introduced API that GNOME 3.x depends on, hence the 2
> >>> >> > recipes. Do all the GNOME 2.x bits build against this new libnotify? The
> >>> >> > error was a build break, so it things build, they are likely to work :)
> >>> >> >
> >>> >> > regards,
> >>> >> >
> >>> >> > Koen
> >>> >> >
> >>> >> Martin's world shall let us know
> >>> >
> >>> > My slaves are looking forward to serve..
> >>> >
> >>> > It's in queue, but still jenkins is 40+ hours behind, so I'll let you know later..
> >>> >
> >>> I started and additional test. At least zenity fails for API change
> >>> but seems not a big deal to fix. Will send follow up patches.
> >>
> >> I guess that to test this properly I should cleansstate both libnotify
> >> or do build from scratch, because I cannot know which one won
> >> into-the-sysroot race during last build.
> >>
> >> --
> > 1. I think yes
> > 2. I found build faults for gnome-power-manager zenity
> > gnome-settings-daemon - hope to fix these until tomorrow.
> >
> > Andreas
> 
> Now after looking into it I suggest to forget these patches. Between
> 0.6.1 and 0.7.x not only the API changed but also the GObject
> interface. The properties
> 
> attach-widget
> status-icon
> 
> were removed. This will cause unpredictable results for applications
> using them. The only chance I see is to put them back but this seems
> more efforts and deep understanding the difference between gtk+ and
> gtk3.

yes seems like there is quite a few build issues

here are last 3 world builds with this change applied:
qemux86:
http://logs.nslu2-linux.org/buildlogs/oe/oe-shr-core-branches/log.world.20130423_042257.log/
qemux86-64:
http://logs.nslu2-linux.org/buildlogs/oe/oe-shr-core-branches/log.world.20130424_014915.log/
qemuarm
http://logs.nslu2-linux.org/buildlogs/oe/oe-shr-core-branches/log.world.20130425_025239.log/

ERROR: Task 5529
(/home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-gnome/recipes-gnome/libgnome/libgnomecanvas_2.26.0.bb,
do_compile) failed with exit code '1'
| gnome-canvas-rich-text.c:2150:2: error: implicit declaration of function 'gtk_text_layout_draw' [-Werror=implicit-function-declaration]

ERROR: Task 8938
(/home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-gnome/recipes-gnome/libgnome/libgnome_2.32.1.bb,
do_compile) failed with exit code '1'
| gnome-program.c:2067:2: error: implicit declaration of function
'g_atexit' [-Werror=implicit-function-declaration]

ERROR: Task 2143
(/home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-gnome/recipes-gnome/gnome-disk-utility/gnome-disk-utility_2.32.0.bb,
do_compile) failed with exit code '1'
| notification-main.c:539:21: error: too many arguments to function
'notify_notification_new'

ERROR: Task 13041
(/home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_2.32.0.bb,
do_compile) failed with exit code '1'
| notify.c:74:2: error: too many arguments to function
'notify_notification_new'

ERROR: Task 10197
(/home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-gnome/recipes-gnome/gnome-settings-daemon/gnome-settings-daemon_2.32.1.bb,
do_compile) failed with exit code '1'
| gsd-a11y-keyboard-manager.c:612:64: error: too many arguments to
function 'notify_notification_new'

ERROR: Task 22117
(/home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-gnome/recipes-gnome/epiphany/epiphany_2.30.6.bb,
do_compile) failed with exit code '1'
| downloader-view.c:340:7: error: too many arguments to function
'notify_notification_new'

ERROR: Task 9420
(/home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-gnome/recipes-gnome/zenity/zenity_2.32.1.bb,
do_compile) failed with exit code '1'
| notification.c:187:11: error: implicit declaration of function
'notify_notification_new_with_status_icon'
[-Werror=implicit-function-declaration]

ERROR: Task 396
(/home/jenkins/oe/shr-core-branches/shr-core/meta-openembedded/meta-gnome/recipes-gnome/gnome-power-manager/gnome-power-manager_2.32.0.bb,
do_compile) failed with exit code '1'
| gpm-manager.c:488:3: error: too many arguments to function
'notify_notification_new'

> Andreas
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]