From: Joe MacDonald <Joe.MacDonald@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing
Date: Tue, 14 May 2013 08:25:06 -0400 [thread overview]
Message-ID: <20130514122505.GC3918@windriver.com> (raw)
In-Reply-To: <1368518279-8029-1-git-send-email-jukka.rissanen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]
[[oe] [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing] On 13.05.14 (Tue 10:57) Jukka Rissanen wrote:
>
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> ---
> This version now properly rdepends on perl-module-io-file instead of
> just the perl package.
>
> Cheers,
> Jukka
>
> meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
> index 2ce9530..a73cd13 100644
> --- a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
> +++ b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
> @@ -6,7 +6,7 @@ PRIORITY = "optional"
> LICENSE = "GPL-2.0+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33"
> DEPENDS = "libgcrypt"
> -RDEPENDS_${PN} = "kernel-module-tun"
> +RDEPENDS_${PN} = "kernel-module-tun perl-module-io-file"
>
> CFLAGS_append = ' -DVERSION=\\"${PV}\\"'
> LDFLAGS_append = " -lgcrypt -lgpg-error"
Given that I'd already merged your previous change (and Koen is
absolutely right, I should've pushed back on it too since I completely
agree with him) can you send out another version of this patch that
addresses his suggestion about reordering the R* variables and is
against the latest tree? This one won't apply as the tree stands now.
Thanks.
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-05-14 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 7:57 [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing Jukka Rissanen
2013-05-14 8:07 ` Koen Kooi
2013-05-14 12:25 ` Joe MacDonald [this message]
2013-05-14 12:46 ` Jukka Rissanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514122505.GC3918@windriver.com \
--to=joe.macdonald@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox