From: Joe MacDonald <Joe.MacDonald@windriver.com>
To: <rongqing.li@windriver.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH meta-networking] arptables: fix the redefinition of 'arpt_get_target' error
Date: Tue, 18 Jun 2013 08:35:17 -0400 [thread overview]
Message-ID: <20130618123516.GA3622@windriver.com> (raw)
In-Reply-To: <1371452640-28576-1-git-send-email-rongqing.li@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 2737 bytes --]
Merged, thanks.
-J.
[[PATCH meta-networking] arptables: fix the redefinition of 'arpt_get_target' error] On 13.06.17 (Mon 15:04) rongqing.li@windriver.com wrote:
> From: "Roy.Li" <rongqing.li@windriver.com>
>
> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> ---
> .../arptables-arpt-get-target-fix.patch | 30 ++++++++++++++++++++
> .../recipes-support/arptables/arptables_0.0.3-4.bb | 1 +
> 2 files changed, 31 insertions(+)
> create mode 100644 meta-networking/recipes-support/arptables/arptables-0.0.3-4/arptables-arpt-get-target-fix.patch
>
> diff --git a/meta-networking/recipes-support/arptables/arptables-0.0.3-4/arptables-arpt-get-target-fix.patch b/meta-networking/recipes-support/arptables/arptables-0.0.3-4/arptables-arpt-get-target-fix.patch
> new file mode 100644
> index 0000000..3f5948b
> --- /dev/null
> +++ b/meta-networking/recipes-support/arptables/arptables-0.0.3-4/arptables-arpt-get-target-fix.patch
> @@ -0,0 +1,30 @@
> +arptables: fix the redefinition of 'arpt_get_target'
> +
> +Upstream-Status: Pending
> +
> +This function is already defined as a static inline function in
> +include/linux/netfilter_arp/arp_tables.h, once GCC uses -O0, the
> +inline will not work, and the redefinition error will happen
> +
> +Signed-off-by: Aws Ismail <aws.ismail@windriver.com>
> +Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> +
> +diff --git a/libarptc/libarptc_incl.c b/libarptc/libarptc_incl.c
> +index 35736db..addd3f9 100644
> +--- a/libarptc/libarptc_incl.c
> ++++ b/libarptc/libarptc_incl.c
> +@@ -11,14 +11,6 @@
> + /* (C)1999 Paul ``Rusty'' Russell - Placed under the GNU GPL (See
> + COPYING for details). */
> +
> +-#ifndef __OPTIMIZE__
> +-STRUCT_ENTRY_TARGET *
> +-GET_TARGET(STRUCT_ENTRY *e)
> +-{
> +- return (void *)e + e->target_offset;
> +-}
> +-#endif
> +-
> + static int sockfd = -1;
> + static void *arptc_fn = NULL;
> +
> diff --git a/meta-networking/recipes-support/arptables/arptables_0.0.3-4.bb b/meta-networking/recipes-support/arptables/arptables_0.0.3-4.bb
> index fe14b61..f3deaeb 100644
> --- a/meta-networking/recipes-support/arptables/arptables_0.0.3-4.bb
> +++ b/meta-networking/recipes-support/arptables/arptables_0.0.3-4.bb
> @@ -12,6 +12,7 @@ SRC_URI = " \
> ${SOURCEFORGE_MIRROR}/ebtables/arptables-v${PV}.tar.gz;name=arptables \
> file://arptables-compile-install.patch \
> file://arptables-init-busybox.patch \
> + file://arptables-arpt-get-target-fix.patch \
> "
> SRC_URI[arptables.md5sum] = "1d4ab05761f063b0751645d8f2b8f8e5"
> SRC_URI[arptables.sha256sum] = "e529fd465c67d69ad335299a043516e6b38cdcd337a5ed21718413e96073f928"
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2013-06-18 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 7:04 [PATCH meta-networking] arptables: fix the redefinition of 'arpt_get_target' error rongqing.li
2013-06-18 12:35 ` Joe MacDonald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618123516.GA3622@windriver.com \
--to=joe.macdonald@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=rongqing.li@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox