Re: [meta-networking][PATCH] dnsmasq: install .service only with systemd in DISTRO_FEATURES

[Joe MacDonald <Joe.MacDonald@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 3684 bytes --]

[Re: [oe] [meta-networking][PATCH] dnsmasq: install .service only with systemd in DISTRO_FEATURES] On 13.07.04 (Thu 13:47) Paul Eggleton wrote:

> On Thursday 04 July 2013 07:18:09 Joe MacDonald wrote:
> > [Re: [oe] [meta-networking][PATCH] dnsmasq: install .service only with 
> systemd in DISTRO_FEATURES] On 13.07.04 (Thu 11:50) Paul Eggleton wrote:
> > > On Thursday 04 July 2013 17:26:23 Chunrong Guo wrote:
> > > > Signed-off-by: Chunrong Guo <B40290@freescale.com>
> > > > ---
> > > > 
> > > >  .../recipes-support/dnsmasq/dnsmasq.inc            |    8 +++++---
> > > >  1 files changed, 5 insertions(+), 3 deletions(-)
> > > > 
> > > > diff --git a/meta-networking/recipes-support/dnsmasq/dnsmasq.inc
> > > > b/meta-networking/recipes-support/dnsmasq/dnsmasq.inc index
> > > > 0f5b273..0710893 100644
> > > > --- a/meta-networking/recipes-support/dnsmasq/dnsmasq.inc
> > > > +++ b/meta-networking/recipes-support/dnsmasq/dnsmasq.inc
> > > > @@ -30,9 +30,11 @@ do_install () {
> > > > 
> > > >      install -d ${D}${sysconfdir}/ ${D}${sysconfdir}/init.d
> > > > 
> > > > ${D}${sysconfdir}/dnsmasq.d install -m 644 ${WORKDIR}/dnsmasq.conf
> > > > ${D}${sysconfdir}/
> > > > 
> > > >      install -m 755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/dnsmasq
> > > > 
> > > > -
> > > > -    install -d ${D}${systemd_unitdir}/system
> > > > -    install -m 0644 ${WORKDIR}/dnsmasq.service
> > > > ${D}${systemd_unitdir}/system +
> > > > +    if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)};
> > > > then +        install -d ${D}${systemd_unitdir}/system
> > > > +        install -m 0644 ${WORKDIR}/dnsmasq.service
> > > > ${D}${systemd_unitdir}/system +    fi
> > > > 
> > > >      if [ "${@base_contains('PACKAGECONFIG', 'dbus', 'dbus', '', d)}" !=
> > > >      ""
> > > > 
> > > > ]; then install -d ${D}${sysconfdir}/dbus-1/system.d
> > > 
> > > I think we should really have a global fix for this issue rather than
> > > hacking up every recipe:
> > > 
> > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=4309
> > 
> > I'm inclined to agree, but looking at the bug it looks like the
> > potential solution was discussed in February and it's on the schedule
> > for Yocto 1.5, but that's October.
> 
> The thing is it could be done by anyone at any time - the bug is at status 
> "NEW" which means the assignee hasn't actually accepted it yet, and the 
> solution being suggested is fairly straightforward. Given that I think it 
> would be easier to just fix the class and then we never have to worry about 
> this issue again.

Sure, (thanks for the clarification on the NEW status, I didn't know
that meant it wasn't necessarily being actively worked) but I would like
to see this solved for anyone building a system with meta-networking and
without systemd.  Unfortunately I don't think I'm the person to make the
updates to systemd.bbclass I know very little about systemd in general
and nothing about systemd.bbclass.

I was a little less averse to taking this workaround (I see it purely as
a workaround until a solution is implemented) since there's precedent
and since the spot that Chunrong is changing for dnsmasq has a very
similar construct immediately following for dbus.  I would prefer,
though, if we do take this kind of workaround, it be done everywhere (at
least in meta-networking) in one operation so it's easy to back out
afterward.

Chunrong, do you want to propose a solution like the one referenced in
the above bug?  Or even the one originally suggested by Paul in the bug?
Or does someone else on the list have a WIP on this item?

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]