Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] samba: remove /var/run from package
Date: Sun, 7 Jul 2013 18:20:10 +0200	[thread overview]
Message-ID: <20130707162010.GH3288@jama> (raw)
In-Reply-To: <1373112225-2084-1-git-send-email-net147@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On Sat, Jul 06, 2013 at 10:03:45PM +1000, Jonathan Liu wrote:
> The /var/run and /var/run/lock directories are already created by
> base-files.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> index a27a28c..6bd6644 100644
> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> @@ -57,3 +57,8 @@ do_configure() {
>  do_compile () {
>      base_do_compile
>  }
> +
> +do_install_append() {
> +    rm -rf "${D}${localstatedir}/run"

Seems like lock removal is missing here.

samba-3.6.8: samba: Files/directories were installed but not shipped
  /run
  /run/lock

Thanks a lot for this patchset, now with libdir and infodir QA checks
we'll see a lot more QA issues in world builds, so it's great to have
this /run gone.


> +    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
> +}
> -- 
> 1.8.3.2
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2013-07-07 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-06 12:03 [meta-oe][PATCH] samba: remove /var/run from package Jonathan Liu
2013-07-07 16:20 ` Martin Jansa [this message]
2013-07-08  5:26   ` Jonathan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130707162010.GH3288@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox