Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH v2] hexedit: new recipe
Date: Sun, 25 Aug 2013 10:02:55 +0200	[thread overview]
Message-ID: <20130825080255.GH3544@jama> (raw)
In-Reply-To: <20130825090907.636cd35c@e6520eb>

[-- Attachment #1: Type: text/plain, Size: 3346 bytes --]

On Sun, Aug 25, 2013 at 09:09:07AM +0200, Eric Bénard wrote:
> Hi Martin,
> 
> Le Thu,  4 Jul 2013 23:47:29 +0200,
> Eric Bénard <eric@eukrea.com> a écrit :
> 
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > ---
> >  .../hexedit/0001-don-t-strip-when-installing.patch |   30 ++++++++++++++++++++
> >  meta-oe/recipes-extended/hexedit/hexedit_1.2.13.bb |   17 +++++++++++
> >  2 files changed, 47 insertions(+)
> >  create mode 100644 meta-oe/recipes-extended/hexedit/hexedit/0001-don-t-strip-when-installing.patch
> >  create mode 100644 meta-oe/recipes-extended/hexedit/hexedit_1.2.13.bb
> > 
> > diff --git a/meta-oe/recipes-extended/hexedit/hexedit/0001-don-t-strip-when-installing.patch b/meta-oe/recipes-extended/hexedit/hexedit/0001-don-t-strip-when-installing.patch
> > new file mode 100644
> > index 0000000..a384b05
> > --- /dev/null
> > +++ b/meta-oe/recipes-extended/hexedit/hexedit/0001-don-t-strip-when-installing.patch
> > @@ -0,0 +1,30 @@
> > +From cc67246ca6839e5b3f6a286f10ed24c225b77a5e Mon Sep 17 00:00:00 2001
> > +From: =?UTF-8?q?Eric=20B=C3=A9nard?= <eric@eukrea.com>
> > +Date: Thu, 4 Jul 2013 12:34:32 +0200
> > +Subject: [PATCH] don't strip when installing
> > +MIME-Version: 1.0
> > +Content-Type: text/plain; charset=UTF-8
> > +Content-Transfer-Encoding: 8bit
> > +
> > +Signed-off-by: Eric Bénard <eric@eukrea.com>
> > +
> > +Upstream-Status: Inappropriate [configuration]
> > +---
> > + Makefile.in |    2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/Makefile.in b/Makefile.in
> > +index 159463e..735cc72 100644
> > +--- a/Makefile.in
> > ++++ b/Makefile.in
> > +@@ -42,6 +42,6 @@ distclean: clean
> > + 
> > + install: $(PRODUCT)
> > + 	$(INSTALL) -d -m 755 $(DESTDIR)$(bindir)
> > +-	$(INSTALL) -s -m 755 $(PRODUCT) $(DESTDIR)$(bindir)
> > ++	$(INSTALL) -m 755 $(PRODUCT) $(DESTDIR)$(bindir)
> > + 	$(INSTALL) -d -m 755 $(DESTDIR)$(mandir)/man1
> > + 	$(INSTALL) -m 644 $(PRODUCT).1 $(DESTDIR)$(mandir)/man1
> > +-- 
> > +1.7.10.4
> > +
> > diff --git a/meta-oe/recipes-extended/hexedit/hexedit_1.2.13.bb b/meta-oe/recipes-extended/hexedit/hexedit_1.2.13.bb
> > new file mode 100644
> > index 0000000..d0658db
> > --- /dev/null
> > +++ b/meta-oe/recipes-extended/hexedit/hexedit_1.2.13.bb
> > @@ -0,0 +1,17 @@
> > +SUMMARY = "view and edit files in hexadecimal or in ASCII"
> > +HOMEPAGE = "http://rigaux.org/hexedit.html"
> > +SECTION = "console/utils"
> > +LICENSE = "GPLv2+"
> > +DEPENDS = "ncurses"
> > +
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
> > +
> > +SRC_URI = "http://rigaux.org/${PN}-${PV}.src.tgz \
> > +    file://0001-don-t-strip-when-installing.patch "
> > +
> > +SRC_URI[md5sum] = "a5af1378d028512a9cad27a5ba3e15f9"
> > +SRC_URI[sha256sum] = "6a126da30a77f5c0b08038aa7a881d910e3b65d13767fb54c58c983963b88dd7"
> > +
> > +inherit autotools
> > +
> > +S = "${WORKDIR}/${PN}"
> 
> is there any problem with this patch which prevent it to be applied ?

I wanted to reply that it was incorrectly marked as Accepted on
patchwork, but Accepted is correct and it was merged 1,5 month ago:

http://git.openembedded.org/meta-openembedded/commit/?id=7da2e2c86e39deba0c1cb08f40efd82b17da17b5

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2013-08-25  8:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04 21:37 [meta-oe][PATCH] hexedit: new recipe Eric Bénard
2013-07-04 21:43 ` Paul Eggleton
2013-07-04 21:47   ` [meta-oe][PATCH v2] " Eric Bénard
2013-08-25  7:09     ` Eric Bénard
2013-08-25  8:02       ` Martin Jansa [this message]
2013-08-25 11:47         ` Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130825080255.GH3544@jama \
    --to=martin.jansa@gmail.com \
    --cc=eric@eukrea.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox