From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Otavio Salvador <otavio@ossystems.com.br>
Subject: Re: [meta-qt5][PATCH] qtbase.inc: Enable accessibility by default
Date: Sun, 4 May 2014 23:47:12 +0200 [thread overview]
Message-ID: <20140504214712.GG2486@jama> (raw)
In-Reply-To: <1398698859-15011-1-git-send-email-otavio@ossystems.com.br>
[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]
On Mon, Apr 28, 2014 at 12:27:39PM -0300, Otavio Salvador wrote:
> qtdeclarative requires accessibility to be enabled and it is added by
> default to the toolchain so we ought to have it enabled to ensure the
> default toolchain generation works.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> recipes-qt/qt5/qtbase.inc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc
> index 89736be..91cadef 100644
> --- a/recipes-qt/qt5/qtbase.inc
> +++ b/recipes-qt/qt5/qtbase.inc
> @@ -39,6 +39,7 @@ PACKAGECONFIG_X11 ?= "${@base_contains('DISTRO_FEATURES', 'x11', 'xcb xvideo xsy
> PACKAGECONFIG_FONTS ?= ""
> PACKAGECONFIG_SYSTEM ?= "jpeg libpng zlib"
> PACKAGECONFIG_MULTIMEDIA ?= "${@base_contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}"
> +PACKAGECONFIG_ACCESSIBILITY ?= "accessibility"
> PACKAGECONFIG_DISTRO ?= ""
> # Either release or debug, can be overridden in bbappends
> PACKAGECONFIG_RELEASE ?= "release"
> @@ -56,6 +57,7 @@ PACKAGECONFIG ?= " \
> ${PACKAGECONFIG_FONTS} \
> ${PACKAGECONFIG_SYSTEM} \
> ${PACKAGECONFIG_MULTIMEDIA} \
> + ${PACKAGECONFIG_ACCESSIBILITY} \
> ${PACKAGECONFIG_DISTRO} \
> "
As I told you on gtalk, I would prefer default to stay as minimal as
posible, why don't you change packagegroup-qt5-toolchain-target.bb to
use RRECOMMENDS instead of RDEPENDS so that missing
qtquickcontrols-qmlplugins package doesn't break it when it's not
available (because it's empty)?
> --
> 1.7.10.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2014-05-04 21:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 15:27 [meta-qt5][PATCH] qtbase.inc: Enable accessibility by default Otavio Salvador
2014-05-02 0:50 ` Jonathan Liu
2014-05-04 21:47 ` Martin Jansa [this message]
2014-05-05 12:21 ` Otavio Salvador
2014-05-14 19:04 ` Otavio Salvador
2014-05-15 8:10 ` Anders Darander
2014-05-15 9:16 ` Samuel Stirtzel
2014-05-15 10:21 ` Martin Jansa
2014-05-15 11:34 ` Samuel Stirtzel
2014-05-15 11:22 ` Jonathan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140504214712.GG2486@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox