Re: [PATCH][meta-networking] openvpn: not use the hardcoded libdir

From: Martin Jansa <martin.jansa@gmail.com>
To: Rongqing Li <rongqing.li@windriver.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH][meta-networking] openvpn: not use the hardcoded libdir
Date: Fri, 25 Jul 2014 12:06:22 +0200	[thread overview]
Message-ID: <20140725100622.GT2492@jama> (raw)
In-Reply-To: <53D1C2F6.4010905@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 2398 bytes --]

On Fri, Jul 25, 2014 at 10:37:42AM +0800, Rongqing Li wrote:
> 
> 
> On 07/24/2014 07:02 PM, Martin Jansa wrote:
> > On Thu, Jul 24, 2014 at 02:43:01PM +0800, rongqing.li@windriver.com wrote:
> >> From: Roy Li <rongqing.li@windriver.com>
> >>
> >> it will lead to QA failure, since .debug dir can not be installed into dbg package
> >>
> >>      ERROR: QA Issue: non debug package contains .debug directory: openvpn path
> >>      /work/core2-64-wrs-linux/openvpn/2.3.4-r0/packages-split/openvpn/usr/lib64i
> >>      /openvpn/plugins/.debug/openvpn-plugin-down-root.so [debug-files]
> >
> > Can you please check this floating dependency?
> >
> > snort/snort/latest lost dependency on  util-linux-libuuid
> >
> 
> Hi, martin:
> 
> 
> This patch is fixing the openvpn, not snort, it should be a good fix.

Ah sorry, I wanted to write it in your next patch which is changing
snort.

> About snort dependency, snort will check if util-linux-libuuid exist or
> not when do configuration, and no configuration options can control it,
> so PACKAGECONFIG can not be used on snort, so I like leave it to wait
> until I have time

OK, I won't block it because of this dependency, but if you're using
snort, then please fix it when you can.

Thanks

> >>
> >> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> >> ---
> >>   meta-networking/recipes-support/openvpn/openvpn_2.3.4.bb |    2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta-networking/recipes-support/openvpn/openvpn_2.3.4.bb b/meta-networking/recipes-support/openvpn/openvpn_2.3.4.bb
> >> index a3322a0..48e04b7 100644
> >> --- a/meta-networking/recipes-support/openvpn/openvpn_2.3.4.bb
> >> +++ b/meta-networking/recipes-support/openvpn/openvpn_2.3.4.bb
> >> @@ -28,4 +28,4 @@ do_install_append() {
> >>
> >>   RRECOMMENDS_${PN} = "kernel-module-tun"
> >>
> >> -FILES_${PN}-dbg += "/usr/lib/openvpn/plugins/.debug"
> >> +FILES_${PN}-dbg += "${libdir}/openvpn/plugins/.debug"
> >> --
> >> 1.7.10.4
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
> >
> 
> -- 
> Best Reagrds,
> Roy | RongQing Li

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]