From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] packagegroups: Move inheriting packagegroup below PACKAGE_ARCH assignment
Date: Tue, 23 Sep 2014 18:29:21 +0200 [thread overview]
Message-ID: <20140923162921.GA25706@jama> (raw)
In-Reply-To: <1411282139-8785-1-git-send-email-raj.khem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2373 bytes --]
On Sat, Sep 20, 2014 at 11:48:59PM -0700, Khem Raj wrote:
> Fixes errors
>
> sets PACKAGE_ARCH before inherit packagegroup
wasn't this already resolved in:
commit 5a25dde053e93e64b945776ab3fbf8b67c8c0773
Author: Martin Jansa <Martin.Jansa@gmail.com>
Date: Sun Aug 24 18:01:11 2014 +0200
packagegroup*: set PACKAGE_ARCH before packagegroup inherit
?
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta-oe/recipes-core/packagegroups/packagegroup-basic.bb | 5 +++--
> meta-oe/recipes-core/packagegroups/packagegroup-boot.bb | 5 +++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb b/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
> index 08db943..9412df2 100644
> --- a/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
> +++ b/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
> @@ -7,12 +7,13 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d
>
> PR = "r13"
>
> -inherit packagegroup
> -
> +#
> # packages which content depend on MACHINE_FEATURES need to be MACHINE_ARCH
> #
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> +inherit packagegroup
> +
> # Poke extra recomendations into the list using your machine.conf
> #
> MACHINE_EXTRA_RRECOMMENDS ?= ""
> diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb b/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
> index 3b634f3..ae7e989 100644
> --- a/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
> +++ b/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
> @@ -4,12 +4,13 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d
>
> PR = "r58"
>
> -inherit packagegroup
> -
> +#
> # packages which content depend on MACHINE_FEATURES need to be MACHINE_ARCH
> #
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> +inherit packagegroup
> +
> #
> # those ones can be set in machine config to supply packages needed to get machine booting
> #
> --
> 2.1.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2014-09-23 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 6:48 [meta-oe][PATCH] packagegroups: Move inheriting packagegroup below PACKAGE_ARCH assignment Khem Raj
2014-09-23 16:29 ` Martin Jansa [this message]
2014-09-23 17:55 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923162921.GA25706@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox