Re: [meta-qt5][PATCH] qtwebengine: backport patches to fix ARM build failures

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3230 bytes --]

On Mon, Oct 20, 2014 at 12:37:21PM +1100, Jonathan Liu wrote:
> On 18 October 2014 22:17, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Sat, Oct 18, 2014 at 11:06:24AM +0200, Martin Jansa wrote:
> >> On Thu, Oct 16, 2014 at 03:44:05PM +1100, Jonathan Liu wrote:
> >> > Signed-off-by: Jonathan Liu <net147@gmail.com>
> >> > ---
> >> >  ...ix-ARM-NEON-detection-for-mfpu-neon-vfpv4.patch | 30 +++++++++++++++++++
> >> >  ...QMAKE_CC-when-extracting-C-compiler-flags.patch | 34 ++++++++++++++++++++++
> >> >  recipes-qt/qt5/qtwebengine_5.3.2+git.bb            |  2 ++
> >> >  recipes-qt/qt5/qtwebengine_git.bb                  |  2 ++
> >> >  4 files changed, 68 insertions(+)
> >> >  create mode 100644 recipes-qt/qt5/qtwebengine/0001-Fix-ARM-NEON-detection-for-mfpu-neon-vfpv4.patch
> >> >  create mode 100644 recipes-qt/qt5/qtwebengine/0002-Include-QMAKE_CC-when-extracting-C-compiler-flags.patch
> >>
> >> This seems to break qemuarm build:
> >>
> >> | No external chromium sources were found, falling back to /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/qtwebengine/5.3.2-r0/git/sr
> >> c/3rdparty/chromium
> >> | Using extra options found in /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/qtwebengine/5.3.2-r0/git/src/core/qmake_extras.gypi
> >> | Using extra options found in /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/qtwebengine/5.3.2-r0/git/src/core/qtwebengine_extras.gy
> >> pi
> >> | Updating projects from gyp files...
> >> | gyp: name 'arm_tune' is not defined while evaluating condition 'arm_tune!=""' in /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/qtw
> >> ebengine/5.3.2-r0/git/src/core/core.gyp
> >> | Project ERROR: -- running gyp_qtwebengine failed --
> >> | WARNING: exit code 3 from a shell command.
> >> | ERROR: Function failed: do_configure (log file is located at /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/qtwebengine/5.3.2-r0/te
> >> mp/log.do_configure.30039)
> >> NOTE: recipe qtwebengine-5.3.2-r0: task do_configure: Failed
> >
> > Probably fixed in
> >
> > commit 1cbb91b4a06d6e6626c5345d5a9d7d0fbe9e1bbb
> > Author: Andras Becsi <andras.becsi@digia.com>
> > Date:   Thu Sep 18 18:22:37 2014 +0200
> >
> >     Set arm_tune to empty string if mtune flag is not set by toolchain
> >
> > which needs to be backported to qtwebengine_5.3.2+git.bb
> >
> > Please re-test and re-send, I'm upgrading _git recipes to 5.4-beta in
> > the mean time so the backport won't be needed in qtwebengine_git.bb.
> 
> Backport of the arm_tune patch looks good to me.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> 
> Does it resolve the qemuarm build failure for you?

Unfortunately not completely, now it's arm_fpu:

| Updating projects from gyp files...
| gyp: name 'arm_fpu' is not defined while evaluating condition 'arm_fpu!=""' in /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/qtwebengine/5.3.2-r0/git/src/core/core.gyp
| Project ERROR: -- running gyp_qtwebengine failed --
| WARNING: exit code 3 from a shell command.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]