Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Qian Lei <qianl.fnst@cn.fujitsu.com>
To: Joe MacDonald <Joe_MacDonald@mentor.com>
Cc: yocto@yoctoproject.org, openembedded-devel@lists.openembedded.org
Subject: Re: [meta-selinux][PATCH] ustr: Change the SRC_URI to upstream and add a new patch
Date: Thu, 20 Nov 2014 09:51:03 +0800	[thread overview]
Message-ID: <20141120095103.2f61ea12@Fedora> (raw)
In-Reply-To: <20141119205646.GL6216@mentor.com>

On Wed, 19 Nov 2014 15:56:47 -0500
Joe MacDonald <Joe_MacDonald@mentor.com> wrote:

> Thanks for the submission.  Just a couple of comments.
> 
> [[oe] [meta-selinux][PATCH] ustr: Change the SRC_URI to upstream and add a
> new patch] On 14.11.19 (Wed 15:34) Qian Lei wrote:
> 
> > Official upstream is still Ok, using it first.
> > Add a new patch which is applied in Fedora20
> 
> As these are two unrelated issues, I think two patches would've been
> appropriate with 1/2 being the one that updates the SRC_URI and 2/2
> being the c99 patch.
> 
> You should also provide an upstream-status for the C99 patch.  As you
> say it came from Fedora, odds are it is already submitted upstream, so
> 'pending' could be appropriate here, but I don't know.
> 
> Finally, meta-selinux patches should go to yocto@yoctoproject.org (cc'd
> here), not the openembedded-dev@ list.
> 
> I'm fine with making the changes I described above or you can send out a
> new version of the patch/patches if you like.  I won't do anything with
> it before tomorrow, either way, to give everyone time to have a look.
> 
> -J.

Thanks for your reply.It really help me a lot. I'll take your advice and send a
new version of patches to yocto soon.

Qian Lei


      reply	other threads:[~2014-11-20  1:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19  7:34 [meta-selinux][PATCH] ustr: Change the SRC_URI to upstream and add a new patch Qian Lei
2014-11-19 20:56 ` Joe MacDonald
2014-11-20  1:51   ` Qian Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141120095103.2f61ea12@Fedora \
    --to=qianl.fnst@cn.fujitsu.com \
    --cc=Joe_MacDonald@mentor.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox