From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] vboxguestdrivers: import recipe from meta-luneos
Date: Mon, 2 Mar 2015 11:26:11 +0100 [thread overview]
Message-ID: <20150302102611.GY2309@jama> (raw)
In-Reply-To: <54F439E6.3010906@dominion.thruhere.net>
[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]
On Mon, Mar 02, 2015 at 11:22:30AM +0100, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Martin Jansa schreef op 02-03-15 om 09:02:
> > * useful to run our qemu* builds inside VirtualBox
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> ---
> > .../vboxguestdrivers/Makefile.utils | 43 ++++++++++++++
> > .../vboxguestdrivers/vboxguestdrivers_4.3.22.bb | 65
> > ++++++++++++++++++++++
>
> > +PACKAGES += "kernel-module-vboxguest kernel-module-vboxsf
> > kernel-module-vboxvideo" +RDEPENDS_${PN} += "kernel-module-vboxguest
> > kernel-module-vboxsf kernel-module-vboxvideo"
>
> Please don't ever RDEPEND on kernel modules, even when the recipe will build
> them, it sets a bad precedent.
I think it makes sense in this case.. nobody will ever include them in
kernel image and vboxguestdrivers utils don't make much sense without
the modules installed.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFU9DnmMkyGM64RGpERAu+jAJ92mQgg4UU7QBoaClZcMsh7Bd/8+wCggBRt
> iXq6vplV1z4aJMxG2xY9+nk=
> =SREn
> -----END PGP SIGNATURE-----
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2015-03-02 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 8:02 [meta-oe][PATCH] vboxguestdrivers: import recipe from meta-luneos Martin Jansa
2015-03-02 10:22 ` Koen Kooi
2015-03-02 10:26 ` Martin Jansa [this message]
2015-03-02 10:55 ` Florian Boor
2015-03-02 11:33 ` Martin Jansa
2015-03-03 9:19 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302102611.GY2309@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox