Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Ash Charles <ashcharles@gmail.com>
Cc: openembedded-commits@lists.openembedded.org,
	openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH v2] mpd: Add build dependency on samba
Date: Wed, 25 Mar 2015 01:11:17 +0100	[thread overview]
Message-ID: <20150325001117.GI3904@jama> (raw)
In-Reply-To: <1427240923-7428-1-git-send-email-ashcharles@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Tue, Mar 24, 2015 at 04:48:43PM -0700, Ash Charles wrote:
> Version 0.19 [1], adds the smbclient plugins for storage and input so
> needs samba when building with the --enable-samba option.
> 
> [1] http://git.musicpd.org/cgit/master/mpd.git/plain/NEWS?h=v0.19
> 
> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> index feec985..f6152a6 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> @@ -20,6 +20,7 @@ EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemds
>  PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
>  PACKAGECONFIG[id3tag] = "--enable-id3,--disable-id3,libid3tag"
>  PACKAGECONFIG[lame] = "--enable-lame-encoder,--disable-lame-encoder,lame"
> +PACKAGECONFIG[smb] = "--enable-smbclient,--disable-smbclient,samba,samba"

You don't need to repeat samba in 4th parameter.

>  
>  do_install_append() {
>      install -d ${D}/${localstatedir}/lib/mpd/music
> -- 
> 2.1.0
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2015-03-25  0:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150112143629.39773504C0@opal.openembedded.org>
2015-03-21 15:32 ` [oe-commits] Ash Charles : mpd: ship systemd socket file Martin Jansa
2015-03-23 16:05   ` [PATCH] mpd: Add build dependency on samba Ash Charles
2015-03-24  5:10     ` Khem Raj
2015-03-24 23:48       ` Ash Charles
2015-03-24 23:48       ` [PATCH v2] " Ash Charles
2015-03-25  0:11         ` Martin Jansa [this message]
2015-03-25  1:49           ` [PATCH v3] " Ash Charles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150325001117.GI3904@jama \
    --to=martin.jansa@gmail.com \
    --cc=ashcharles@gmail.com \
    --cc=openembedded-commits@lists.openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox