Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-systemd][PATCH] bluez4_4.101.bbappend: update according to bluez4
Date: Thu, 23 Apr 2015 19:00:40 +0200	[thread overview]
Message-ID: <20150423170040.GE2336@jama> (raw)
In-Reply-To: <969F26A8BAB325438E7EB80D3C3134FB2F4B50F7@irsmsx105.ger.corp.intel.com>

On Thu, Apr 23, 2015 at 04:21:17PM +0000, Iorga, Cristian wrote:
> What is left into that bbappend is not suitable for inclusion into bluez4 recipe.

Why? Every other recipe in meta-openembedded layers already has these
lines.

> I am not sure why I should move it meta-oe... Does not seem to be present in oe-core. Or am I wrong?

top level directory in meta-systemd says in which layer the recipe is
(now there are only .bbappends for oe-core, because the rest was already
migrated to corresponding layers), you're moving bluez4 recipes from
oe-core to meta-oe, so this .bbappend should be moved as well.

> 
> Thanks,
> Cristian
> 
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Martin Jansa
> Sent: Thursday, April 23, 2015 6:16 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-systemd][PATCH] bluez4_4.101.bbappend: update according to bluez4
> 
> On Thu, Apr 23, 2015 at 05:27:31PM +0300, Cristian Iorga wrote:
> > bluez4 recipe has been updated with proper systemd support, so update 
> > meta-systemd append accordingly.
> > 
> > Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> > ---
> >  .../oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappend         | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git 
> > a/meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappen
> > d 
> > b/meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappen
> > d
> > index da01b05..260c02e 100644
> > --- 
> > a/meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappen
> > d
> > +++ b/meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bba
> > +++ ppend
> 
> It should be either moved from oe-core to meta-oe directory or better merged into bluez4 recipe and removed from meta-systemd.
> 
> > @@ -1,9 +1,4 @@
> > -inherit systemd
> > -
> > -EXTRA_OECONF += "--with-systemdunitdir=${systemd_unitdir}/system/"
> > -
> >  RPROVIDES_${PN} += "${PN}-systemd"
> >  RREPLACES_${PN} += "${PN}-systemd"
> >  RCONFLICTS_${PN} += "${PN}-systemd"
> > -SYSTEMD_SERVICE_${PN} = "bluetooth.service"
> >  SYSTEMD_AUTO_ENABLE = "disable"
> > --
> > 2.1.0
> > 
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


      reply	other threads:[~2015-04-23 17:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 14:27 [meta-systemd][PATCH] bluez4_4.101.bbappend: update according to bluez4 Cristian Iorga
2015-04-23 15:16 ` Martin Jansa
2015-04-23 16:21   ` Iorga, Cristian
2015-04-23 17:00     ` Martin Jansa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150423170040.GE2336@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox