From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][PATCH] qmake5_base.bbclass: fix typo
Date: Wed, 29 Apr 2015 16:27:18 +0200 [thread overview]
Message-ID: <20150429142718.GA2369@jama> (raw)
In-Reply-To: <1242158112.3767308.1430230347909.JavaMail.root@openwide.fr>
On Tue, Apr 28, 2015 at 04:12:27PM +0200, Alexis Cellier wrote:
> In the qt.conf file created, fix typo on "TargetSpec" (was "TartgetSpec").
How was this tested before sending?
In my builds it causes:
| Cannot read /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtbase/5.4.1+gitAUTOINC+f58e882b75-r0/build/mkspecs/linux-oe-g++/qmake.conf: No such file or directory
| Could not read qmake configuration file /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtbase/5.4.1+gitAUTOINC+f58e882b75-r0/build/mkspecs/linux-oe-g++/qmake.conf.
So I agree it's a typo, but if we cannot make it work, then we should
remove the line completely.
>
> Signed-off-by: Alexis Cellier <alexis.cellier@openwide.fr>
> ---
> classes/qmake5_base.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/qmake5_base.bbclass b/classes/qmake5_base.bbclass
> index 44575c4..dbdaf78 100644
> --- a/classes/qmake5_base.bbclass
> +++ b/classes/qmake5_base.bbclass
> @@ -79,7 +79,7 @@ HostBinaries = ${OE_QMAKE_PATH_HOST_BINS}
> HostData = ${OE_QMAKE_PATH_HOST_DATA}
> HostLibraries = ${OE_QMAKE_PATH_HOST_LIBS}
> HostSpec = ${OE_QMAKESPEC}
> -TartgetSpec = ${OE_XQMAKESPEC}
> +TargetSpec = ${OE_XQMAKESPEC}
> ExternalHostBinaries = ${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}
> Sysroot = ${STAGING_DIR_TARGET}
> EOF
> --
> 2.3.5
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
next prev parent reply other threads:[~2015-04-29 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1620830615.3767281.1430230294080.JavaMail.root@openwide.fr>
2015-04-28 14:12 ` [meta-qt5][PATCH] qmake5_base.bbclass: fix typo Alexis Cellier
2015-04-29 14:27 ` Martin Jansa [this message]
2015-04-29 16:34 ` Alexis Cellier
2015-04-29 17:21 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429142718.GA2369@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox