Re: [PATCH][meta-networking] netkit-telnet: support the cross-compile

[Joe MacDonald <Joe_MacDonald@mentor.com>]

[-- Attachment #1: Type: text/plain, Size: 4339 bytes --]

Hi Roy,

[[PATCH][meta-networking] netkit-telnet: support the cross-compile] On 15.04.16 (Thu 16:35) rongqing.li@windriver.com wrote:

> From: Roy Li <rongqing.li@windriver.com>
> 
> when check the CC, only compile the object by CC, not run the object.
> MCONFIG file includes more configuration, we can not clear it
> 
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
>  .../netkit-telnet/files/cross-compile.patch        | 48 ++++++++++++++++++++++
>  .../netkit-telnet/netkit-telnet_0.17.bb            |  6 ++-
>  2 files changed, 53 insertions(+), 1 deletion(-)
>  create mode 100644 meta-networking/recipes-netkit/netkit-telnet/files/cross-compile.patch
> 
> diff --git a/meta-networking/recipes-netkit/netkit-telnet/files/cross-compile.patch b/meta-networking/recipes-netkit/netkit-telnet/files/cross-compile.patch
> new file mode 100644
> index 0000000..b3fe36b
> --- /dev/null
> +++ b/meta-networking/recipes-netkit/netkit-telnet/files/cross-compile.patch
> @@ -0,0 +1,48 @@
> +To support the cross-compile
> +
> +Upstream-Status: Pending
> +
> +make the configure to support the cross-compile, by only to compile the
> +target, and not to run it
> +
> +Roy Li <rongqing.li@windriver.com>

I guess you meant to make this a signed-off-by line.

Also, this looks like a re-submission of the patch initially from Li Xin
at Fujitsu last November.  It was dropped in the v2 of the recipe and I
didn't ask any more after it, but can you follow-up on the requests I
had regarding it at the time?

http://lists.openembedded.org/pipermail/openembedded-devel/2014-November/098982.html

-J.

> +Index: netkit-telnet-0.17/configure
> +===================================================================
> +--- netkit-telnet-0.17.orig/configure	2008-11-23 22:01:26.000000000 +0100
> ++++ netkit-telnet-0.17/configure	2008-11-23 22:05:00.000000000 +0100
> +@@ -94,7 +94,7 @@
> +     echo -n 'Checking if C compiler works... '
> +     if (
> +           $CC __conftest.c -o __conftest || exit 1
> +-          ./__conftest || exit 1
> ++          # Idiots belong shot! ./__conftest || exit 1
> +        ) >/dev/null 2>&1; then
> +          echo 'yes'
> +      else
> +@@ -141,7 +141,7 @@
> +     echo -n 'Checking if C++ compiler works... '
> +     if (
> +           $CXX __conftest.cc -o __conftest || exit 1
> +-          ./__conftest || exit 1
> ++          # Iditios belong shot! ./__conftest || exit 1
> +        ) >/dev/null 2>&1; then
> +          echo 'yes'
> +      else
> +@@ -284,7 +284,7 @@
> + else
> +     if (
> +           $CXX $CXXFLAGS -D__USE_BSD_SIGNAL __conftest.cc  -o __conftest || exit 1
> +-          ./__conftest || exit 1
> ++          # running still does not work./__conftest || exit 1
> +        ) >/dev/null 2>&1; then
> +         echo '-D__USE_BSD_SIGNAL'
> +         CFLAGS="$CFLAGS -D__USE_BSD_SIGNAL"
> +@@ -501,7 +501,7 @@
> + EOF
> + if (
> +       $CXX $CXXFLAGS  __conftest.cc $LIBBSD -o __conftest || exit 1
> +-      ./__conftest || exit 1
> ++      # argh! morons!./__conftest || exit 1
> +    ) >/dev/null 2>&1; then
> +     echo 'ok'
> + else
> diff --git a/meta-networking/recipes-netkit/netkit-telnet/netkit-telnet_0.17.bb b/meta-networking/recipes-netkit/netkit-telnet/netkit-telnet_0.17.bb
> index a2dc1c2..6b2e72f 100644
> --- a/meta-networking/recipes-netkit/netkit-telnet/netkit-telnet_0.17.bb
> +++ b/meta-networking/recipes-netkit/netkit-telnet/netkit-telnet_0.17.bb
> @@ -8,6 +8,7 @@ SRC_URI = "ftp://ftp.uk.linux.org/pub/linux/Networking/netkit/${BP}.tar.gz \
>      file://To-aviod-buffer-overflow-in-telnet.patch \
>      file://Warning-fix-in-the-step-of-install.patch \
>      file://telnet-xinetd \
> +    file://cross-compile.patch \
>  "
>  
>  EXTRA_OEMAKE = "INSTALLROOT=${D} SBINDIR=${sbindir} DAEMONMODE=755 \
> @@ -15,7 +16,10 @@ EXTRA_OEMAKE = "INSTALLROOT=${D} SBINDIR=${sbindir} DAEMONMODE=755 \
>  
>  do_configure () {
>      ./configure --prefix=${prefix}
> -    echo "LDFLAGS=${LDFLAGS}" > MCONFIG
> +    sed -e 's#^CFLAGS=\(.*\)$#CFLAGS= -D_GNU_SOURCE \1#' \
> +        -e 's#^CXXFLAGS=\(.*\)$#CXXFLAGS= -D_GNU_SOURCE \1#' \
> +        -e 's#^LDFLAGS=.*$#LDFLAGS= ${LDFLAGS}#' \
> +        -i MCONFIG
>  }
>  
>  do_compile () {
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]