Re: [PATCH] libjpeg-turbo: fix libturbojpeg packaging

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2513 bytes --]

On Wed, Sep 02, 2015 at 12:10:59PM +0100, ml@communistcode.co.uk wrote:
> From: Jack Mitchell <jack@embed.me.uk>
> 
> put libjpegturbo library files and headers into correct packages rather
> than them being in the main libjpeg-turbo package.
> 
> remove INSANE_SKIP[dev-so]
> move .so, .a into -dev package
> move .la into -staticdev
> move .so.* into main library package
> 
> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
> ---
>  meta-oe/recipes-core/jpeg/libjpeg-turbo_8d+1.4.0.bb | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-oe/recipes-core/jpeg/libjpeg-turbo_8d+1.4.0.bb b/meta-oe/recipes-core/jpeg/libjpeg-turbo_8d+1.4.0.bb
> index 8e214c9..16f62c5 100644
> --- a/meta-oe/recipes-core/jpeg/libjpeg-turbo_8d+1.4.0.bb
> +++ b/meta-oe/recipes-core/jpeg/libjpeg-turbo_8d+1.4.0.bb
> @@ -25,13 +25,14 @@ inherit autotools pkgconfig
>  
>  EXTRA_OECONF = "--with-jpeg8 "
>  
> -PACKAGES =+ "jpeg-tools libturbojpeg"
> +PACKAGES =+ "jpeg-tools libturbojpeg libturbojpeg-staticdev libturbojpeg-dev"
>  
>  DESCRIPTION_jpeg-tools = "The jpeg-tools package includes client programs to access libjpeg functionality.  These tools allow for the compression, decompression, transformation and display of JPEG files and benchmarking of the libjpeg library."
>  FILES_jpeg-tools = "${bindir}/*"
>  
> -FILES_libturbojpeg = "${libdir}/libturbojpeg.so"
> -INSANE_SKIP_libturbojpeg = "dev-so"
> +FILES_libturbojpeg = "${libdir}/libturbojpeg.so.*"

You can use libturbojpeg*${SOLIBS}

> +FILES_libturbojpeg-staticdev = "${libdir}/libturbojpeg.a"
> +FILES_libturbojpeg-dev = "${libdir}/libturbojpeg.la ${incdir}/turbojpeg.h ${libdir}/libturbojpeg.so"

libturbojpeg.so -> lib*${SOLIBSDEV} and we should use only one
-dev/-staticdev package for recipe (people who need to install
-dev/-staticdef package to rootfs usually don't mind getting few more
files installed as well).

But more importantly I don't understand how dev-so and other files got
into libturbojpeg package when it's using:

FILES_libturbojpeg = "${libdir}/libturbojpeg.so"

So I think the problem is somewhere else.
>  
>  BBCLASSEXTEND = "native"
>  DEPENDS = "nasm-native"
> -- 
> 2.5.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]