Re: [PATCH][meta-oe 1/9] ipsec-tools: set MACHINE_ARCH, because it depends on kernel

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 4454 bytes --]

On Thu, Nov 12, 2015 at 04:10:09PM +0100, Andreas Müller wrote:
> On Thu, Nov 12, 2015 at 3:49 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Thu, Nov 12, 2015 at 03:39:12PM +0100, Andreas Müller wrote:
> >> On Thu, Nov 12, 2015 at 3:22 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> > * see:
> >> >   http://lists.openembedded.org/pipermail/openembedded-devel/2015-September/103271.html
> >> > * fixes:
> >> > ERROR: ipsec-tools different signature for task do_configure.sigdata between qemux86copy and qemux86
> >> > runtaskdeps changed from ['autoconfautoconf_2.69.bb.do_populate_sysroot:virtual:native', 'automakeautomake_1.15.bb.do_populate_sysroot:virtual:native', 'bisonbison_3.0.4.bb.do_populate_sysroot:virtual:native', 'flexflex_2.5.39.bb.do_populate_sysroot:virtual:native', 'gccgcc-cross_5.2.bb.do_populate_sysroot', 'gccgcc-runtime_5.2.bb.do_populate_sysroot', 'glibcglibc_2.22.bb.do_populate_sysroot', 'gnu-configgnu-config_git.bb.do_populate_sysroot:virtual:native', 'ipsec-toolsipsec-tools_0.8.2.bb.do_patch', 'libtoollibtool-cross_2.4.6.bb.do_populate_sysroot', 'libtoollibtool-native_2.4.6.bb.do_populate_sysroot', 'linuxlinux-yocto_4.1.bb.do_populate_sysroot', 'opensslopenssl_1.0.2d.bb.do_populate_sysroot', 'readlinereadline_6.3.bb.do_populate_sysroot', 'systemdsystemd-systemctl-native.bb.do_populate_sysroot']
> >> > to
> >> > ['autoconfautoconf_2.69.bb.do_populate_sysroot:virtual:native', 'automakeautomake_1.15.bb.do_populate_sysroot:virtual:native', 'bisonbison_3.0.4.bb.do_populate_sysroot:virtual:native', 'flexflex_2.5.39.bb.do_populate_sysroot:virtual:native', 'gccgcc-cross_5.2.bb.do_populate_sysroot', 'gccgcc-runtime_5.2.bb.do_populate_sysroot', 'glibcglibc_2.22.bb.do_populate_sysroot', 'gnu-configgnu-config_git.bb.do_populate_sysroot:virtual:native', 'ipsec-toolsipsec-tools_0.8.2.bb.do_patch', 'libtoollibtool-cross_2.4.6.bb.do_populate_sysroot', 'libtoollibtool-native_2.4.6.bb.do_populate_sysroot', 'linuxlinux-yocto_4.1.bb.do_populate_sysroot', 'opensslopenssl_1.0.2d.bb.do_populate_sysroot', 'readlinereadline_6.3.bb.do_populate_sysroot', 'systemdsystemd-systemctl-native.bb.do_populate_sysroot']
> >> > openembedded-core/meta/recipes-kernel/linux/linux-yocto_4.1.bb.do_populate_sysroot with hash 1a8aa7a50a6cf3ebf5401af43dd6bf3b
> >> >  changed to
> >> > openembedded-core/meta/recipes-kernel/linux/linux-yocto_4.1.bb.do_populate_sysroot with hash 143d2686a37f592891fb2aa6fa9b752e
> >> > Hash for dependent task linuxlinux-yocto_4.1.bb.do_populate_sysroot changed from 1a8aa7a50a6cf3ebf5401af43dd6bf3b to 143d2686a37f592891fb2aa6fa9b752e
> >> >
> >> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >> > ---
> >> >  meta-networking/recipes-support/ipsec-tools/ipsec-tools_0.8.2.bb | 2 ++
> >> >  1 file changed, 2 insertions(+)
> >> >
> >> > diff --git a/meta-networking/recipes-support/ipsec-tools/ipsec-tools_0.8.2.bb b/meta-networking/recipes-support/ipsec-tools/ipsec-tools_0.8.2.bb
> >> > index 8ee81f8..d9f1212 100644
> >> > --- a/meta-networking/recipes-support/ipsec-tools/ipsec-tools_0.8.2.bb
> >> > +++ b/meta-networking/recipes-support/ipsec-tools/ipsec-tools_0.8.2.bb
> >> > @@ -7,6 +7,8 @@ LIC_FILES_CHKSUM = "file://src/libipsec/pfkey.c;beginline=6;endline=31;md5=bc9b7
> >> >
> >> >  DEPENDS = "virtual/kernel openssl readline flex-native bison-native"
> >> >
> >> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >> > +
> >> >  SRC_URI = "ftp://ftp.netbsd.org/pub/NetBSD/misc/ipsec-tools/0.8/ipsec-tools-${PV}.tar.bz2 \
> >> >             file://0002-Don-t-link-against-libfl.patch \
> >> >             file://configure.patch \
> >> > --
> >> > 2.6.3
> >> >
> >> Maybe I am wrong: I think there were times when depending on kernel
> >> made recipe machine specific. I somehow get the feeling that this is
> >> the wrong fix...
> >
> > That's what this patch is doing, or I didn't get your point.
> >
> I thought there was once a magic doing this automatically: As soon as
> there is one package in depends which is machine specific this recipe
> also turns machine specififc.

The magic PACKAGE_ARCH works only for SRC_URI files when they are found ${MACHINE}
directory in FILESPATH.

> But the more I think over this, it seems I am mixing this up with
> inheriting modules - which does turn the recipe into machine specific.
> So forget my question.

OK, done :)

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]