Re: [meta-oe][PATCH V2 02/17] modemmanager: Update to 1.4.12

From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH V2 02/17] modemmanager: Update to 1.4.12
Date: Wed, 18 Nov 2015 15:33:30 +0100	[thread overview]
Message-ID: <20151118143330.GC2213@jama> (raw)
In-Reply-To: <20151116212303.GD2240@jama>

[-- Attachment #1: Type: text/plain, Size: 3195 bytes --]

On Mon, Nov 16, 2015 at 10:23:03PM +0100, Martin Jansa wrote:
> On Wed, Nov 11, 2015 at 08:48:05PM +0100, Adrian Freihofer wrote:
> >  - Fixes segfaults, memleaks and other bugs
> >  - Support more modems
> > 
> > Signed-off-by: Adrian Freihofer <adrian.freihofer@gmail.com>
> > ---
> >  .../{modemmanager_1.4.2.bb => modemmanager_1.4.12.bb}        | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >  rename meta-oe/recipes-connectivity/modemmanager/{modemmanager_1.4.2.bb => modemmanager_1.4.12.bb} (71%)
> > 
> > diff --git a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.2.bb b/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.12.bb
> > similarity index 71%
> > rename from meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.2.bb
> > rename to meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.12.bb
> > index b273c91..db7a28d 100644
> > --- a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.2.bb
> > +++ b/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.12.bb
> > @@ -1,19 +1,19 @@
> >  SUMMARY = "ModemManager is a daemon controlling broadband devices/connections"
> >  DESCRIPTION = "ModemManager is a DBus-activated daemon which controls mobile broadband (2G/3G/4G) devices and connections"
> >  HOMEPAGE = "http://www.freedesktop.org/wiki/Software/ModemManager/"
> > -LICENSE = "GPLv2 & LGPLv2.1"
> > +LICENSE = "GPL-2.0 & LGPL-2.1"
> >  LIC_FILES_CHKSUM = " \
> >      file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> >      file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c \
> >  "
> >  
> > -inherit autotools gettext gtk-doc systemd
> > +inherit gnomebase gettext systemd
> >  
> > -DEPENDS = "glib-2.0 libmbim libqmi polkit libgudev dbus-glib"
> > +DEPENDS = "glib-2.0 libmbim libqmi (>=1.12.4) polkit libgudev dbus-glib"
> 
> bitbake doesn't support versioned dependencies, I've removed
> "(>=1.12.4)" when cherry-picking to master-next, but I wonder how you
> were able to test this.
> 
> > -SRC_URI = "http://www.freedesktop.org/software/ModemManager/ModemManager-${PV}.tar.xz"
> > -SRC_URI[md5sum] = "fe74eaa9a77e51e552b4356b4c7195cb"
> > -SRC_URI[sha256sum] = "07d332fbe6f45f788f740810951e04042aaf023bd5ecf8ef0b3a06e37703585d"
> > +SRC_URI = "${GNOME_MIRROR}/ModemManager/ModemManager-${PV}.tar.xz"

Why do you think it exists on GNOME_MIRROR?

http://ftp.gnome.org/pub/GNOME/sources/ModemManager/
shows only versions til 0.7.991

I'll undo this change for next build, but please be more careful next
time and really test the changes.

> > +SRC_URI[md5sum] = "66cc7266b15525cb366253e6639fc564"
> > +SRC_URI[sha256sum] = "7ef5035375a953b285a742591df0a65fd442f4641ce4d8f4392a41d6d6bc70b3" 
> >  
> >  S = "${WORKDIR}/ModemManager-${PV}"
> >  
> > -- 
> > 2.4.3
> > 
> > -- 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]