Re: [meta-networking][PATCH] ntp: remove empty libexecdir to prevent potential QA issues

[Joe MacDonald <Joe_MacDonald@mentor.com>]

[-- Attachment #1: Type: text/plain, Size: 2954 bytes --]

[Re: [oe] [meta-networking][PATCH] ntp: remove empty libexecdir to prevent potential QA issues] On 16.02.04 (Thu 18:07) Martin Jansa wrote:

> On Thu, Feb 04, 2016 at 11:51:56AM -0500, Mark Asselstine wrote:
> > On Thu, Feb 4, 2016 at 11:07 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > > On Thu, Feb 04, 2016 at 10:08:33AM -0500, Mark Asselstine wrote:
> > >> Depending on the configuration used to build ntp it is possible to
> > >> have an empty libexecdir. This can cause QA issues. Add a test at the
> > >> end of install() to remove libexecdir if it is empty, thus avoiding
> > >> the possibility of QA issues, regardless of configuration.
> > >>
> > >> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> > >> ---
> > >>  meta-networking/recipes-support/ntp/ntp_4.2.8p4.bb | 3 +++
> > >>  1 file changed, 3 insertions(+)
> > >>
> > >> diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.8p4.bb b/meta-networking/recipes-support/ntp/ntp_4.2.8p4.bb
> > >> index f9f900e..cb09e77 100644
> > >> --- a/meta-networking/recipes-support/ntp/ntp_4.2.8p4.bb
> > >> +++ b/meta-networking/recipes-support/ntp/ntp_4.2.8p4.bb
> > >> @@ -94,6 +94,9 @@ do_install_append() {
> > >>
> > >>      install -d ${D}${systemd_unitdir}/ntp-units.d
> > >>      install -m 0644 ${WORKDIR}/ntpd.list ${D}${systemd_unitdir}/ntp-units.d/60-ntpd.list
> > >> +
> > >> +    # Remove an empty libexecdir.
> > >> +    [ ! "$(ls -A ${D}${libexecdir})" ] && rm -r ${D}${libexecdir}
> > >
> > > Isn't this the same as:
> > >
> > > rmdir --ignore-fail-on-non-empty ${D}${libexecdir}
> > >
> > > ?
> > 
> > It appears to be. rmdir is not a command I use often so I didn't look
> > to see if it was suitable for the job. Want me to resend with rmdir or
> > you care to make the swap prior to merging?
> 
> Joe is maintainer of meta-networking, but I would prefer you to send v2.

Yeah, please do.

-J.

> 
> > Mark
> > 
> > 
> > >
> > >>  }
> > >>
> > >>  PACKAGES += "ntpdate sntp ${PN}-tickadj ${PN}-utils"
> > >> --
> > >> 2.1.4
> > >>
> > >> --
> > >> _______________________________________________
> > >> Openembedded-devel mailing list
> > >> Openembedded-devel@lists.openembedded.org
> > >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > >
> > > --
> > > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > >
> > -- 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com



-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]