Re: [meta-oe][PATCH] fluentbit: add new recipe

From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] fluentbit: add new recipe
Date: Sat, 2 Apr 2016 20:17:14 +0200	[thread overview]
Message-ID: <20160402181714.GG2567@jama> (raw)
In-Reply-To: <CAEaCVQjW0cmMDNyc3LhZQxv+RWfVmx9Bj-qgQx9AH1_+0=sTDA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3430 bytes --]

On Fri, Apr 01, 2016 at 11:20:49AM -0600, Eduardo Silva wrote:
> on this case should be "RDEPENDS_${PN} = "zlib" OK ?

NO

> On Fri, Apr 1, 2016 at 11:01 AM, Eduardo Silva <eduardo@monkey.io> wrote:
> 
> > Oh, sorry I misunderstood. The program requires zlib to run, so it's a
> > build (headers) and runtime dependency.
> >
> > On Fri, Apr 1, 2016 at 10:57 AM, Martin Jansa <martin.jansa@gmail.com>
> > wrote:
> >
> >> Then it's probably build time dependency as the warning says, not runtime
> >> dependency like you did.
> >>
> >> Read what the component build does, if it checks for zlib in configure
> >> then
> >> you really need to add it to DEPENDS not RDEPENDS_${PN}.
> >>
> >> On Fri, Apr 1, 2016 at 6:53 PM, Eduardo Silva <eduardo@monkey.io> wrote:
> >>
> >> > > +LIC_FILES_CHKSUM =
> >> > "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
> >> >
> >> > >
> >> > > LIC_FILES_CHKSUM is relative to ${S}, so LIC_FILES_CHKSUM =
> >> > > "file://LICENSE.. should work fine
> >> > >
> >> > >
> >> > Thanks, I have updated my local copy
> >> >
> >> >
> >> > > > +
> >> > > > +RDEPENDS_${PN} = "zlib"
> >> > >
> >> > > If it does link with libz then the runtime dependency should be added
> >> > > automatically by shlibs code in package.bbclass if it's not the case
> >> > > can you add comment explaining why it needs to be added explicitly?
> >> > >
> >> > >
> >> > I added that because I got a QA warning message:
> >> >
> >> > WARNING: QA Issue: fluentbit-dev rdepends on zlib, but it isn't a build
> >> > dependency? [build-deps]
> >> > WARNING: QA Issue: fluentbit rdepends on zlib, but it isn't a build
> >> > dependency? [build-deps]
> >> >
> >> > what's your suggestion in this case ?
> >> >
> >> > best
> >> >
> >> >
> >> >
> >> > > > +
> >> > > > +inherit cmake
> >> > > > --
> >> > > > 2.5.0
> >> > > >
> >> > > > --
> >> > > > _______________________________________________
> >> > > > Openembedded-devel mailing list
> >> > > > Openembedded-devel@lists.openembedded.org
> >> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >> > >
> >> > > --
> >> > > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >> > >
> >> > > --
> >> > > _______________________________________________
> >> > > Openembedded-devel mailing list
> >> > > Openembedded-devel@lists.openembedded.org
> >> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >> > >
> >> > >
> >> >
> >> >
> >> > --
> >> > Eduardo Silva
> >> > Monkey Software
> >> > --
> >> > _______________________________________________
> >> > Openembedded-devel mailing list
> >> > Openembedded-devel@lists.openembedded.org
> >> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >> >
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> >
> >
> >
> > --
> > Eduardo Silva
> > Monkey Software
> >
> 
> 
> 
> -- 
> Eduardo Silva
> Monkey Software
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]