Re: [meta-python][PATCHv3 1/3] python-backports-abc: initial recipe for version 0.4 RDEPENDS

["S. Lockwood-Childs" <sjl@vctlabs.com>]

On Fri, Jun 03, 2016 at 07:47:50AM +0200, Gary Thomas wrote:
> On 06/03/2016 07:38 AM, S. Lockwood-Childs wrote:
> >On Fri, Jun 03, 2016 at 07:03:22AM +0200, Gary Thomas wrote:
> >>On 06/02/2016 08:26 PM, S. Lockwood-Childs wrote:
> >>>Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
> >>>from bombing on import errors when running on python2 rather than python3.4
> >>>
> >>>   ImportError: No module named backports_abc
> >>>
> >>>Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
> >>
> >>In my mind, this patch (and its sibling) don't really have anything to to
> >>with Tornado, they are just new packages being added to make that package happy.
> >>I'd prefer to see a commit message that reflects what this package is as well
> >>as why it is being added.
> >
> >>>+SUMMARY = "collections.abc from Python 3.4"
> >>>+DESCRIPTION = "A backport of recent additions to the 'collections.abc' module"
> >
> >What would you like to see, a repeat of the SUMMARY or DESCRIPTION lines
> >added to the corresponding commit messages (if so, which)?
> >
> >Other than that, I don't know what else to say about them; if their absence
> >wasn't breaking Tornado, I would not have picked either of these particular
> >modules to submit. Neither one has much use yet outside of Tornado (found no
> >other users of abc, while singledispatch is also used by rpy (python interface
> >to R).
> >
> 
> I would think the SUMMARY would be OK, along with a note that the package was
> introduced to make Tornado happy.  (I know this is just "eye candy", but it does
> help when searching through git logs...)
> 
> Thanks for doing this - I was about to make similar changes myself.

I am all for having useful git logs.

And at least it gives me a reason to resubmit the patch series without the 
typo that came back (grrr) though Martin was nice enough not to make me.