From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Cc: Denys Dmytriyenko <denys@ti.com>
Subject: Re: [meta-qt5][krogoth][PATCH] cmake_qt5.bbclass: when using _prepend don't forget to add space at the end
Date: Thu, 28 Jul 2016 14:38:30 -0400 [thread overview]
Message-ID: <20160728183830.GK8521@denix.org> (raw)
In-Reply-To: <CA+chaQcBrDH-Ns30KX=fuBqzKPBn4Xh3zkgfOZwpb9=PO5UKhQ@mail.gmail.com>
On Thu, Jul 28, 2016 at 08:08:35PM +0200, Martin Jansa wrote:
> Is the same needed in master branch?
Yes, just sent separately - had to update commit id, as I used the one from
krogoth below...
--
Denys
> On Thu, Jul 28, 2016 at 7:00 PM, Denys Dmytriyenko <denis@denix.org> wrote:
>
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > Previous commit aacd63f10dd58acf7bf6138e2f4734e37dcf0420 introduced a bug
> > by
> > using _prepend w/o a space at the end, resulting in corrupted EXTRA_OEMAKE
> > variable in packages that inherit cmake_qt5.bbclass.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> > classes/cmake_qt5.bbclass | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
> > index 4dc897b..3180fd6 100644
> > --- a/classes/cmake_qt5.bbclass
> > +++ b/classes/cmake_qt5.bbclass
> > @@ -32,4 +32,5 @@ EXTRA_OECMAKE_prepend = " \
> > -DOE_QMAKE_PATH_QT_DOCS=${OE_QMAKE_PATH_QT_DOCS} \
> > -DOE_QMAKE_PATH_QT_SETTINGS=${OE_QMAKE_PATH_QT_SETTINGS} \
> > -DOE_QMAKE_PATH_QT_EXAMPLES=${OE_QMAKE_PATH_QT_EXAMPLES} \
> > - -DOE_QMAKE_PATH_QT_TESTS=${OE_QMAKE_PATH_QT_TESTS}"
> > + -DOE_QMAKE_PATH_QT_TESTS=${OE_QMAKE_PATH_QT_TESTS} \
> > +"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
prev parent reply other threads:[~2016-07-28 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 17:00 [meta-qt5][krogoth][PATCH] cmake_qt5.bbclass: when using _prepend don't forget to add space at the end Denys Dmytriyenko
2016-07-28 18:08 ` Martin Jansa
2016-07-28 18:38 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728183830.GK8521@denix.org \
--to=denis@denix.org \
--cc=denys@ti.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox