Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Cody P Schafer <dev@codyps.com>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-oe][PATCH] meta-oe/thrift: fix build on gcc-6
Date: Fri,  9 Sep 2016 16:26:45 -0400	[thread overview]
Message-ID: <20160909202645.23148-1-dev@codyps.com> (raw)

thrift build issues on gcc-6 were essentially 2 issues:

 - gcc-6 has stricter overflow checking on array declaration, and
   thrift was using `char` when it should have used `signed char`
 - gcc-6 is really picky about it's include paths (`-I`), and thrift
   had a bad habbit of passing internal ones when it was cross compiled
   due to how it was using `include_directories()`

This adds 2 patches (both variations of those submitted upstream, the
ones included here are rebased onto thrift-0.9.3).

	https://issues.apache.org/jira/browse/THRIFT-3831
	https://issues.apache.org/jira/browse/THRIFT-3828

Signed-off-by: Cody P Schafer <dev@codyps.com>
---
 meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb b/meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
index ce0b492..fdea7f1 100644
--- a/meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
+++ b/meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
@@ -10,6 +10,8 @@ DEPENDS = "thrift-native boost python libevent flex-native bison-native \
 
 SRC_URI = "git://git-wip-us.apache.org/repos/asf/thrift.git;protocol=https \
            file://0001-Forcibly-disable-check-for-Qt5.patch \
+           file://0001-THRIFT-3828-In-cmake-avoid-use-of-both-quoted-paths-.patch \
+           file://0002-THRIFT-3831-in-test-cpp-explicitly-use-signed-char.patch \
 "
 SRCREV = "61b8a29b0704ccd81b520f2300f5d1bb261fea3e"
 S = "${WORKDIR}/git"
@@ -32,6 +34,3 @@ EXTRA_OECMAKE_class-nativesdk = "-DWITH_QT4=OFF -DWITH_QT5=OFF \
 do_install_append () {
     ln -sf thrift ${D}/${bindir}/thrift-compiler
 }
-
-# http://errors.yoctoproject.org/Errors/Details/68622/
-PNBLACKLIST[thrift] ?= "BROKEN: fails to build with gcc-6"
-- 
2.9.3



                 reply	other threads:[~2016-09-09 20:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160909202645.23148-1-dev@codyps.com \
    --to=dev@codyps.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox