Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH v2] phytool: Add recipe
Date: Wed, 5 Oct 2016 18:32:47 +0200	[thread overview]
Message-ID: <20161005163247.GC2926@jama> (raw)
In-Reply-To: <CAMKF1sqTt+xuBTo4JyBDMUaHoygpuVUgcjQWyGfM9DAobaioyQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2193 bytes --]

On Wed, Oct 05, 2016 at 08:38:07AM -0700, Khem Raj wrote:
> On Wed, Oct 5, 2016 at 2:34 AM, Mike Looijmans <mike.looijmans@topic.nl> wrote:
> > A nice tool to directly read, write and interpret ethernet PHY data.
> > Very useful when debugging PHY or MDIO problems, which ethtool does
> > not do.
> >
> > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> > ---
> > v2: Fix LICENSE filename and checksum
> >     Honor LDFLAGS value (patch accepted upstream)
> >
> >  meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
> >
> > diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb
> > new file mode 100644
> > index 0000000..d451aa9
> > --- /dev/null
> > +++ b/meta-networking/recipes-support/phytool/phytool.bb
> > @@ -0,0 +1,14 @@
> > +SUMMARY = "PHY interface tool for Linux"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0"
> > +
> > +PV = "1.0.1"
> 
> perhaps its better to include SRCPV in PV above since the SRCREV
> below is really 1.0.1+some more commits. moreover we get srcrev
> accounted for task hashes
> 
> > +SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2"
> > +SRC_URI = "git://github.com/wkz/phytool.git"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +do_install() {
> > +       install -d ${D}${prefix}/bin
> > +       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install

We're not using tabs for indentation.
see http://www.openembedded.org/wiki/Styleguide

> > +}
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]

  reply	other threads:[~2016-10-05 16:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23 12:33 [meta-networking][PATCH] phytool: Add recipe Mike Looijmans
2016-09-23 18:33 ` Khem Raj
2016-09-24 15:01   ` Mike Looijmans
2016-09-26  7:31     ` Khem Raj
2016-09-26 20:34       ` Martin Jansa
2016-09-28  7:30         ` Mike Looijmans
2016-09-28  7:55           ` Mike Looijmans
2016-10-05  9:34         ` [meta-networking][PATCH v2] " Mike Looijmans
2016-10-05 15:38           ` Khem Raj
2016-10-05 16:32             ` Martin Jansa [this message]
2016-10-06  5:54               ` Mike Looijmans
2016-09-28  7:53 ` [PATCH " Mike Looijmans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161005163247.GC2926@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox