openembedded-devel.lists.openembedded.org archive mirror
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Alejandro Mery <amery@hanoverdisplays.com>
Cc: "amery@geeks.cl" <amery@geeks.cl>,
	"openembedded-devel@lists.openembedded.org"
	<openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH] gitver: fix try/except syntax for python3 support
Date: Sat, 4 Mar 2017 12:53:47 +0100	[thread overview]
Message-ID: <20170304115347.GC3025@jama> (raw)
In-Reply-To: <CF323D845261FD4F9B1E99738125033460DE2603@maildb.hanover.local>

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

On Wed, Mar 01, 2017 at 02:22:29PM +0000, Alejandro Mery wrote:
> On 01/03/17 14:19, Alejandro Mery wrote:
> > https://www.python.org/dev/peps/pep-3110/
> >
> > It's backward compatible with 2.6+
> >
> > Signed-off-by: Alejandro Mery <amery@hanoverdisplays.com>
> > ---
> >  meta-oe/classes/gitver.bbclass | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/classes/gitver.bbclass b/meta-oe/classes/gitver.bbclass
> > index e7b5155ee..b677996ea 100644
> > --- a/meta-oe/classes/gitver.bbclass
> > +++ b/meta-oe/classes/gitver.bbclass
> > @@ -27,13 +27,13 @@ def get_git_pv(path, d, tagadjust=None):
> >      gitdir = os.path.abspath(os.path.join(d.getVar("S", True), ".git"))
> >      try:
> >          ver = gitrev_run("git describe --tags", gitdir)
> > -    except Exception, exc:
> > +    except Exception as exc:
> >          bb.fatal(str(exc))
> >
> >      if not ver:
> >          try:
> >              ver = gitrev_run("git rev-parse --short HEAD", gitdir)
> > -        except Exception, exc:
> > +        except Exception as exc:
> >              bb.fatal(str(exc))
> >
> >          if ver:
> 
> I forgot to mention, I'm having this problem using `morty`

Next time, please send version applicable and tested in master branch first, then
you can request backport to morty.

I've applied this manually to master-next now.

Thanks

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

  reply	other threads:[~2017-03-04 11:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 14:19 [meta-oe][PATCH] gitver: fix try/except syntax for python3 support Alejandro Mery
2017-03-01 14:22 ` Alejandro Mery
2017-03-04 11:53   ` Martin Jansa [this message]
2017-03-04 13:35     ` Alejandro Mery
2017-03-04 14:55       ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170304115347.GC3025@jama \
    --to=martin.jansa@gmail.com \
    --cc=amery@geeks.cl \
    --cc=amery@hanoverdisplays.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).