From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-oe][PATCH 01/14] t1lib: Fix printf format string errors
Date: Mon, 6 Mar 2017 23:13:36 -0800 [thread overview]
Message-ID: <20170307071349.16444-1-raj.khem@gmail.com> (raw)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
.../t1lib/t1lib-5.1.2/format_security.patch | 41 ++++++++++++++++++++++
meta-oe/recipes-extended/t1lib/t1lib_5.1.2.bb | 3 +-
2 files changed, 43 insertions(+), 1 deletion(-)
create mode 100644 meta-oe/recipes-extended/t1lib/t1lib-5.1.2/format_security.patch
diff --git a/meta-oe/recipes-extended/t1lib/t1lib-5.1.2/format_security.patch b/meta-oe/recipes-extended/t1lib/t1lib-5.1.2/format_security.patch
new file mode 100644
index 000000000..8b4ce400f
--- /dev/null
+++ b/meta-oe/recipes-extended/t1lib/t1lib-5.1.2/format_security.patch
@@ -0,0 +1,41 @@
+Fix printf formats to use format qualifiers
+fixes
+
+error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+Upstream-Status: Pending
+
+--- a/lib/type1/objects.c
++++ b/lib/type1/objects.c
+@@ -957,7 +957,7 @@
+
+ sprintf(typemsg, "Wrong object type in %s; expected %s, found %s.\n",
+ name, TypeFmt(expect), TypeFmt(obj->type));
+- IfTrace0(TRUE,typemsg);
++ IfTrace1(TRUE, "%s", typemsg);
+
+ ObjectPostMortem(obj);
+
+--- a/lib/t1lib/t1subset.c
++++ b/lib/t1lib/t1subset.c
+@@ -759,7 +759,7 @@
+ tr_len);
+ T1_PrintLog( "T1_SubsetFont()", err_warn_msg_buf,
+ T1LOG_DEBUG);
+- l+=sprintf( &(trailerbuf[l]), linebuf); /* contains the PostScript trailer */
++ l+=sprintf( &(trailerbuf[l]), "%s", linebuf); /* contains the PostScript trailer */
+ }
+
+ /* compute size of output file */
+--- a/lib/type1/objects.h
++++ b/lib/type1/objects.h
+@@ -214,7 +214,7 @@
+ /*SHARED*/
+ /* NDW: personally, I want to see status and error messages! */
+ #define IfTrace0(condition,model) \
+- {if (condition) printf(model);}
++ {if (condition) fputs(model,stdout);}
+ #define IfTrace1(condition,model,arg0) \
+ {if (condition) printf(model,arg0);}
+ #define IfTrace2(condition,model,arg0,arg1) \
diff --git a/meta-oe/recipes-extended/t1lib/t1lib_5.1.2.bb b/meta-oe/recipes-extended/t1lib/t1lib_5.1.2.bb
index 1d670a7d7..826dbda85 100644
--- a/meta-oe/recipes-extended/t1lib/t1lib_5.1.2.bb
+++ b/meta-oe/recipes-extended/t1lib/t1lib_5.1.2.bb
@@ -9,7 +9,8 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=8ca43cbc842c2336e835926c2166c28b \
SRC_URI = "${DEBIAN_MIRROR}/main/t/t1lib/t1lib_${PV}.orig.tar.gz \
file://configure.patch \
- file://libtool.patch"
+ file://libtool.patch \
+ file://format_security.patch"
SRC_URI[md5sum] = "a5629b56b93134377718009df1435f3c"
SRC_URI[sha256sum] = "821328b5054f7890a0d0cd2f52825270705df3641dbd476d58d17e56ed957b59"
--
2.12.0
next reply other threads:[~2017-03-07 7:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 7:13 Khem Raj [this message]
2017-03-07 7:13 ` [meta-oe][PATCH 02/14] fftw: Update to 3.3.6 release Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 03/14] libxml++: Update to 2.40.1 Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 04/14] gpm: Update to use git src uri Khem Raj
2017-03-08 10:16 ` Martin Jansa
2017-03-08 10:18 ` Martin Jansa
2017-03-29 11:05 ` Martin Jansa
2017-03-29 14:06 ` Khem Raj
2017-03-29 14:21 ` Martin Jansa
2017-03-29 14:30 ` Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 05/14] grail: Disable elision warnings for clang Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 06/14] gperftools: Fix build with clang Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 07/14] tbb: Update to 2017 release Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 08/14] irssi: Upgrade to 1.0.1 Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 09/14] a2jmidid: Fix build on aarch64 Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 10/14] log4c: Backport patch to fix security format errors with clang Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 11/14] rapidjson: Update to 1.1.0 + git Khem Raj
2017-03-08 10:19 ` Martin Jansa
2017-03-07 7:13 ` [meta-oe][PATCH 12/14] ltrace: Fix build with aarch64 and bump to latest Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 13/14] iptraf: Fix build with clang Khem Raj
2017-03-07 7:13 ` [meta-oe][PATCH 14/14] libtorrent, rtorrent: Update to 0.13.6+git Khem Raj
2017-03-08 10:17 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307071349.16444-1-raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox