From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [PATCH][meta-oe 6/9] vboxguestdrivers: make sure that do_compile fails when some module failed to build
Date: Wed, 29 Mar 2017 11:16:40 +0200 [thread overview]
Message-ID: <20170329091643.32180-6-Martin.Jansa@gmail.com> (raw)
In-Reply-To: <20170329091643.32180-1-Martin.Jansa@gmail.com>
* otherwise we get the failure from do_install with useless log:
DEBUG: Executing shell function do_install
install: cannot stat 'vboxsf.ko': No such file or directory
WARNING: exit code 1 from a shell command.
* instead of the real issue like 5.1.14 currently has with default linux-yocto
version:
CC [M] qemux86-oe-linux/vboxguestdrivers/5.1.14-r0/vbox_module/vboxsf/lnkops.o
qemux86-oe-linux/vboxguestdrivers/5.1.14-r0/vbox_module/vboxsf/lnkops.c:93:23: error: 'generic_readlink' undeclared here (not in a function)
.readlink = generic_readlink,
^~~~~~~~~~~~~~~~
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_4.3.36.bb | 4 ++++
meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_5.1.14.bb | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_4.3.36.bb b/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_4.3.36.bb
index f8a24a508..0c08d97f8 100644
--- a/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_4.3.36.bb
+++ b/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_4.3.36.bb
@@ -41,6 +41,10 @@ do_export_sources() {
# compile and install mount utility
do_compile_append() {
oe_runmake 'LD=${CC}' 'LDFLAGS=${LDFLAGS}' -C ${S}/utils
+ if ! [ -e vboxguest.ko -a -e vboxsf.ko -a -e vboxvideo.ko ] ; then
+ echo "ERROR: One of vbox*.ko modules wasn't built"
+ exit 1
+ fi
}
module_do_install() {
diff --git a/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_5.1.14.bb b/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_5.1.14.bb
index dde5b0b20..c27791e95 100644
--- a/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_5.1.14.bb
+++ b/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_5.1.14.bb
@@ -41,6 +41,10 @@ do_export_sources() {
# compile and install mount utility
do_compile_append() {
oe_runmake 'LD=${CC}' 'LDFLAGS=${LDFLAGS}' -C ${S}/utils
+ if ! [ -e vboxguest.ko -a -e vboxsf.ko -a -e vboxvideo.ko ] ; then
+ echo "ERROR: One of vbox*.ko modules wasn't built"
+ exit 1
+ fi
}
module_do_install() {
--
2.12.2
next prev parent reply other threads:[~2017-03-29 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 9:16 [PATCH][meta-oe 1/9] hwdata: use github instead of fedorahosted.org Martin Jansa
2017-03-29 9:16 ` [PATCH][meta-oe 2/9] mailcap: use pagure.org instead of retired fedorahosted.org Martin Jansa
2017-03-29 9:16 ` [PATCH][meta-oe 3/9] libqb: use github.com " Martin Jansa
2017-03-30 4:50 ` Khem Raj
2017-03-29 9:16 ` [PATCH][meta-oe 4/9] ttf-abyssinica: fix SRC_URI Martin Jansa
2017-03-29 9:16 ` [PATCH][meta-oe 5/9] ttf-liberation-sans-narrow: use pagure.org instead of retired fedorahosted.org Martin Jansa
2017-03-29 9:16 ` Martin Jansa [this message]
2017-03-29 9:16 ` [PATCH][meta-oe 7/9] vboxguestdrivers: upgrade to 5.1.18 to fix compatibility with 4.10 kernel Martin Jansa
2017-03-29 9:16 ` [PATCH][meta-oe 8/9] tcsh, dt: blacklist because tcsh doesn't respect CC variable Martin Jansa
2017-03-29 9:16 ` [PATCH][meta-oe 9/9] zile: fix do_install Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329091643.32180-6-Martin.Jansa@gmail.com \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox