Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-xfce][PATCH 09/43] xfce4-timer-plugin: Fix build when security flags are enabled with clang
Date: Fri, 31 Mar 2017 09:42:13 -0700	[thread overview]
Message-ID: <20170331164247.5052-9-raj.khem@gmail.com> (raw)
In-Reply-To: <20170331164247.5052-1-raj.khem@gmail.com>

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../0001-Specify-string-format-explicitly.patch    | 32 ++++++++++++++++++++++
 .../timer/xfce4-timer-plugin_1.6.0.bb              |  2 ++
 2 files changed, 34 insertions(+)
 create mode 100644 meta-xfce/recipes-panel-plugins/timer/xfce4-timer-plugin/0001-Specify-string-format-explicitly.patch

diff --git a/meta-xfce/recipes-panel-plugins/timer/xfce4-timer-plugin/0001-Specify-string-format-explicitly.patch b/meta-xfce/recipes-panel-plugins/timer/xfce4-timer-plugin/0001-Specify-string-format-explicitly.patch
new file mode 100644
index 000000000..3f0bb05af
--- /dev/null
+++ b/meta-xfce/recipes-panel-plugins/timer/xfce4-timer-plugin/0001-Specify-string-format-explicitly.patch
@@ -0,0 +1,32 @@
+From 6b786e1c161026ab5486ac218891a85db65bf3ba Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Wed, 22 Mar 2017 15:28:24 -0700
+Subject: [PATCH] Specify string format explicitly
+
+Avoids below errors when compiling with -Wformat-security
+
+error: format string is not a string literal (potentially insecure)
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+Upstream-Status: Pending
+
+ src/xfcetimer.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/xfcetimer.c b/src/xfcetimer.c
+index 601772f..4b89682 100644
+--- a/src/xfcetimer.c
++++ b/src/xfcetimer.c
+@@ -190,7 +190,7 @@ static gboolean update_function (gpointer data){
+ 
+     dialog = gtk_message_dialog_new (NULL, GTK_DIALOG_MODAL,
+                                     GTK_MESSAGE_WARNING,
+-                                    GTK_BUTTONS_NONE, dialog_message);
++                                    GTK_BUTTONS_NONE, "%s", dialog_message);
+                            
+     gtk_window_set_title ((GtkWindow *) dialog, dialog_title);                                    
+  
+-- 
+2.12.0
+
diff --git a/meta-xfce/recipes-panel-plugins/timer/xfce4-timer-plugin_1.6.0.bb b/meta-xfce/recipes-panel-plugins/timer/xfce4-timer-plugin_1.6.0.bb
index d61235fe0..961519285 100644
--- a/meta-xfce/recipes-panel-plugins/timer/xfce4-timer-plugin_1.6.0.bb
+++ b/meta-xfce/recipes-panel-plugins/timer/xfce4-timer-plugin_1.6.0.bb
@@ -6,5 +6,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=ae39271267fd63eb7619432ff24e7ff1"
 
 inherit xfce-panel-plugin
 
+SRC_URI += "file://0001-Specify-string-format-explicitly.patch"
+
 SRC_URI[md5sum] = "3be2a4ccfb2af20441b1d25c2cea5f28"
 SRC_URI[sha256sum] = "39d7d21f099bc4219f6a6156142f0bbb8374986ee1970a9c0c8dc138b87f867c"
-- 
2.12.1



  parent reply	other threads:[~2017-03-31 16:43 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 16:42 [meta-oe][PATCH 01/43] gpm: Update to use git src uri Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 02/43] netcat-openbsd: Fix build and whitelist Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 03/43] ctdb: Fix build with musl Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 04/43] v4l-utils: Depend on argp-standalone for musl Khem Raj
2017-03-31 16:42 ` [meta-multimedia][PATCH 05/43] caps: Use c99 int types Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 06/43] lvm2: Fix patch errors found with musl Khem Raj
2017-04-01  3:50   ` Peter Kjellerstedt
2017-04-01 15:20     ` Khem Raj
2017-04-05 17:17       ` Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 07/43] squid: Update to 3.5.23 Khem Raj
2017-03-31 16:42 ` [meta-xfce][PATCH 08/43] xfce4-closebutton-plugin: Fix build with clang Khem Raj
2017-03-31 16:42 ` Khem Raj [this message]
2017-03-31 16:42 ` [meta-oe][PATCH 10/43] tcsh: Update to 6.20.00 release Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 11/43] libnfnetlink: Backport patches to fix musl build Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 12/43] ebtables: Fix build with musl Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 13/43] poco: Upgrade to 1.7.8 Khem Raj
2017-04-07 17:42   ` Martin Jansa
2017-04-07 22:21     ` Khem Raj
2017-04-07 23:43       ` Khem Raj
2017-04-08  7:20         ` Martin Jansa
2017-03-31 16:42 ` [meta-oe][PATCH 14/43] mariadb: Do not use ucontext_* APIs with musl Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 15/43] lowpan-tools: Fix build " Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 16/43] usb-modeswitch-data: Add dep on native tcl Khem Raj
2017-03-31 16:42 ` [meta-filesystems][PATCH 17/43] aufs-util: Define HOSTCC Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 18/43] ttf-inconsolata: Move copying of .otf to .ttf into do_compile Khem Raj
2017-04-02  7:14   ` Martin Jansa
2017-04-05 16:56     ` Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 19/43] libraw1394: Update to 2.1.2 release Khem Raj
2017-03-31 16:42 ` [meta-multimedia][PATCH 20/43] libdc1394: Update to 2.2.5+ Khem Raj
2017-03-31 16:42 ` [meta-filesystems][PATCH 21/43] ntfs-3g-ntfsprogs: Upgrade to 2017.3.23 Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 22/43] openl2tp: Fix build with musl Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 23/43] rp-pppoe: " Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 24/43] minicoredumper: Update to 2.0.0 Khem Raj
2017-04-02  7:14   ` Martin Jansa
2017-04-05 17:05     ` Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 25/43] vsftpd: Fix build with musl Khem Raj
2017-03-31 16:42 ` [meta-multimedia][PATCH 26/43] faac: Fix with with security flags and on musl Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 27/43] dibbler: Upgrade to 1.0.2RC1 Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 28/43] live555: Do not use XLOCALE on musl Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 29/43] libqb: Upgrade to 1.0.1 release Khem Raj
2017-04-03 14:18   ` Martin Jansa
2017-04-05 16:49     ` Khem Raj
2017-04-06  7:30       ` Martin Jansa
2017-03-31 16:42 ` [meta-oe][PATCH 30/43] libgxim: Fix build with security flags turned on Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 31/43] vpnc: Update to build from github SRC_URI Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 32/43] daq: Fix build with musl Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 33/43] utouch: Fix build on musl Khem Raj
2017-03-31 16:42 ` [meta-multimedia][PATCH 34/43] libavc1394: Add libargp " Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH V2 35/43] picocom: Upgrade to 2.2 Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH V2 36/43] libexecinfo: Add recipe Khem Raj
2017-03-31 16:42 ` [meta-xfce][PATCH 37/43] xarchiver: Fix build with security flags turned on Khem Raj
2017-04-02  7:16   ` Martin Jansa
2017-04-05 17:14     ` Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 38/43] arptables: Upgrade to 0.0.4 Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 39/43] libnetfilter-log: Switch to git URI Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 40/43] lxdm: Find libexecinfo if its on platform Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 41/43] libnetfilter-queue: Update to git for SRC_URI Khem Raj
2017-03-31 16:42 ` [meta-oe][PATCH 42/43] libunique: Fix build with secutiy flags on Khem Raj
2017-03-31 16:42 ` [meta-networking][PATCH 43/43] snort: Fix build with musl Khem Raj
2017-04-03 19:19 ` [meta-oe][PATCH 01/43] gpm: Update to use git src uri Martin Jansa
2017-04-05 16:38   ` Khem Raj
2017-04-05 17:41     ` Martin Jansa
2017-04-05 17:57       ` Khem Raj
2017-04-05 17:58       ` Khem Raj
2017-04-05 18:36         ` Martin Jansa
2017-04-05 19:37           ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331164247.5052-9-raj.khem@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox