From: <kai.kang@windriver.com>
To: <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: [PATCH 1/2] gflags: correct S and update library install directory
Date: Wed, 12 Apr 2017 09:42:00 +0800 [thread overview]
Message-ID: <20170412014201.23476-2-kai.kang@windriver.com> (raw)
In-Reply-To: <20170412014201.23476-1-kai.kang@windriver.com>
From: Kai Kang <kai.kang@windriver.com>
The current setting of S is not right for multilib. Remove the setting
and use the default value.
And library install directory is not right for multilib either. It fails
with [installed-vs-shipped] QA error:
| ERROR: gflags-2.2.0-r0 do_package: QA Issue: gflags: Files/directories
| were installed but not shipped in any package:
| /usr/lib/libgflags.so
| /usr/lib/libgflags_nothreads.so.2.2
Set cmake variable LIB_INSTALL_DIR with ${baselib} to fix the issue.
Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
meta-oe/recipes-support/gflags/gflags_2.2.0.bb | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/meta-oe/recipes-support/gflags/gflags_2.2.0.bb b/meta-oe/recipes-support/gflags/gflags_2.2.0.bb
index b9188c3..f2092a3 100644
--- a/meta-oe/recipes-support/gflags/gflags_2.2.0.bb
+++ b/meta-oe/recipes-support/gflags/gflags_2.2.0.bb
@@ -8,13 +8,12 @@ LIC_FILES_CHKSUM = "file://COPYING.txt;md5=c80d1a3b623f72bb85a4c75b556551df"
SRC_URI = "https://github.com/gflags/gflags/archive/v${PV}.tar.gz"
SRC_URI[md5sum] = "b99048d9ab82d8c56e876fb1456c285e"
SRC_URI[sha256sum] = "466c36c6508a451734e4f4d76825cf9cd9b8716d2b70ef36479ae40f08271f88"
-S = "${WORKDIR}/${PN}-${PV}/"
FILES_${PN}-dev += "${libdir}/cmake"
inherit cmake
-EXTRA_OECMAKE="-DBUILD_SHARED_LIBS=ON -DREGISTER_INSTALL_PREFIX=OFF"
+EXTRA_OECMAKE="-DBUILD_SHARED_LIBS=ON -DREGISTER_INSTALL_PREFIX=OFF -DLIB_INSTALL_DIR=${baselib}"
PACKAGES =+ "${PN}-bash-completion"
FILES_${PN}-bash-completion += "${bindir}/gflags_completions.sh"
--
2.10.1
next prev parent reply other threads:[~2017-04-12 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 1:41 [meta-oe][PATCH 0/2] V3: Fix gflags and opencv build errors for multilib kai.kang
2017-04-12 1:42 ` kai.kang [this message]
2017-04-12 1:42 ` [PATCH 2/2] opencv: correct subpackage name " kai.kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412014201.23476-2-kai.kang@windriver.com \
--to=kai.kang@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox