Re: [PATCH] fluidsynth: update 1.1.6 -> 1.1.8

[Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>]

On Mon, 16 Oct 2017 21:44:23 +0200
Andreas Müller <schnitzeltony@googlemail.com> wrote:

> On Mon, Oct 16, 2017 at 7:40 PM, Leonardo Sandoval <
> leonardo.sandoval.gonzalez@linux.intel.com> wrote:
> 
> > On Mon, 16 Oct 2017 12:42:28 +0200
> > Andreas Müller <schnitzeltony@googlemail.com> wrote:
> >
> > > * project has moved from sourceforge to github
> > > * autotools was replaced by cmake [1]
> >
> > Worth noting that  license changed from LGPL-2.0+ to LPGL-2.1.
> 
> Yes I forgot to mention
> 
> > In case you send a v2, use a lower -M value for your git-format-patch
> > command, this may detect the rename.
> >
> I have
> 
> [diff]
>     renames = true

I use git-format-patch which by defaults does renames with 50 of similarity index (defined by -M). I believe there is a git-diff-config for the latter value.

> 
> in my .gitconfig which does this job fine usually. I think rename due to
> changes in almost all lines.
> 
> V2 required?

worth it in my opinion.

I just format your patch with the -M2 and this is the output, indicating that lots of stuff change but makes it easier to read.

diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
similarity index 23%
rename from meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
rename to meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
index 88981e44b..754fadc2e 100644
--- a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
+++ b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
@@ -1,23 +1,19 @@
 SUMMARY = "Fluidsynth is a software synthesizer"
 HOMEPAGE = "http://www.fluidsynth.org/"
 SECTION = "libs/multimedia"
-LICENSE = "LGPL-2.0+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=e198e9aac94943d0ec29a7dae8c29416"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
 
 DEPENDS = "alsa-lib ncurses glib-2.0"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/project/${BPN}/${BP}/${BP}.tar.gz"
-SRC_URI[md5sum] = "ae5aca6de824b4173667cbd3a310b263"
-SRC_URI[sha256sum] = "50853391d9ebeda9b4db787efb23f98b1e26b7296dd2bb5d0d96b5bccee2171c"
+SRC_URI = "git://github.com/FluidSynth/fluidsynth.git;branch=1.1.x"
+SRCREV = "12e7afe3a806a6b397f28e0ca4bc6bab9ebe7047"
+S = "${WORKDIR}/git"
 
-inherit autotools-brokensep pkgconfig lib_package
+inherit cmake pkgconfig lib_package
 
 PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio', d)}"
-PACKAGECONFIG[sndfile] = "--enable-libsndfile-support,--disable-libsndfile-support,libsndfile1"
-PACKAGECONFIG[jack] = "--enable-jack-support,--disable-jack-support,jack"
-PACKAGECONFIG[pulseaudio] = "--enable-pulse-support,--disable-pulse-support,pulseaudio"
-PACKAGECONFIG[portaudio] = "--enable-portaudio-support,--disable-portaudio-support,portaudio-v19"
-
-do_configure_prepend () {
-    rm -f ${S}/m4/*
-}
+PACKAGECONFIG[sndfile] = "-Denable-libsndfile-support=ON,-Denable-libsndfile-support=OFF,libsndfile1"
+PACKAGECONFIG[jack] = "-Denable-jack-support=ON,-Denable-jack-support=OFF,jack"
+PACKAGECONFIG[pulseaudio] = "-Denable-pulseaudio=ON,--Denable-pulseaudio=OFF,pulseaudio"
+PACKAGECONFIG[portaudio] = "-Denable-portaudio=ON,-Denable-portaudio=OFF,portaudio-v19"



> 
> Andreas
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>