Re: [meta-networking][PATCH] samba: Add packagegroup

[Andreas Oberritter <obi@opendreambox.org>]

On Fri, 8 Dec 2017 19:19:30 +0800
zhengrq <zhengrq.fnst@cn.fujitsu.com> wrote:

> Add packagegroup for samba, for there are too many rpms in samba and it's hard to manage.
> 
> Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
> ---
>  .../recipes-connectivity/samba/samba_4.6.7.bb      | 30 +++++++++++++++++++++-
>  1 file changed, 29 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb b/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
> index 2b227c9..83846b1 100644
> --- a/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
> @@ -162,7 +162,7 @@ PACKAGES =+ "${PN}-python ${PN}-pidl \
>               ${PN}-dsdb-modules ${PN}-testsuite registry-tools \
>               winbind \
>               ${PN}-common ${PN}-base ${PN}-ctdb-tests \
> -             smbclient"
> +             smbclient ${PN}-client ${PN}-server ${PN}-test"
>  
>  python samba_populate_packages() {
>      def module_hook(file, pkg, pattern, format, basename):
> @@ -254,3 +254,31 @@ FILES_smbclient = "${bindir}/cifsdd \
>  
>  RDEPENDS_${PN}-pidl_append = " perl"
>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
> +
> +SUMMARY_${PN}-client = "samba client"
> +RDEPENDS_${PN}-client = "\
> +    smbclient \
> +    winbind \
> +    registry-tools \
> +    ${PN}-pidl \
> +    " 
> +
> +ALLOW_EMPTY_${PN}-client = "1"
> +
> +SUMMARY_${PN}-server = "samba server"
> +RDEPENDS_${PN}-server = "\
> +    ${PN} \
> +    winbind \
> +    registry-tools \
> +    ${PN}-pidl \
> +    " 

The list of packages for the server installation changed significantly since
your previous patch without further explanation.

Are you sure Perl is required to run the Samba server now? I'm asking, because
I've been using a minimal installation (samba-base) for years.

> +
> +ALLOW_EMPTY_${PN}-server = "1"
> +
> +SUMMARY_${PN}-test = "samba test"
> +RDEPENDS_${PN}-test = "\
> +    ${PN}-ctdb-tests \
> +    ${PN}-testsuite \
> +    "
> +
> +ALLOW_EMPTY_${PN}-test = "1"

Please remove the SUMMARY fields, or choose more descriptive texts.

Regards,
Andreas