From: Joshua Watt <jpewhacker@gmail.com>
To: openembedded-devel@lists.openembedded.org,
Joe MacDonald <joe_macdonald@mentor.com>
Subject: [meta-networking][PATCH] ebtables: Remove bashisms
Date: Fri, 12 Jan 2018 09:02:56 -0600 [thread overview]
Message-ID: <20180112150256.24391-1-JPEWhacker@gmail.com> (raw)
Removes the bashism of prefacing shell functions with "function" and
renames the clear function to not conflict with the command of the same
name.
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
.../ebtables/ebtables-2.0.10-4/ebtables.common | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/meta-networking/recipes-filter/ebtables/ebtables-2.0.10-4/ebtables.common b/meta-networking/recipes-filter/ebtables/ebtables-2.0.10-4/ebtables.common
index 640025dba..1ae18fed3 100644
--- a/meta-networking/recipes-filter/ebtables/ebtables-2.0.10-4/ebtables.common
+++ b/meta-networking/recipes-filter/ebtables/ebtables-2.0.10-4/ebtables.common
@@ -20,7 +20,7 @@ EBTABLES_BACKUP_SUFFIX="~"
config=/etc/default/$prog
[ -f "$config" ] && . "$config"
-function get_supported_tables() {
+get_supported_tables() {
EBTABLES_SUPPORTED_TABLES=
/sbin/ebtables -t filter -L 2>&1 1>/dev/null | grep -q permission
if [ $? -eq 0 ]; then
@@ -35,7 +35,7 @@ function get_supported_tables() {
done
}
-function load() {
+load() {
RETVAL=0
get_supported_tables
echo -n "Restoring ebtables rulesets: "
@@ -64,7 +64,7 @@ function load() {
fi
}
-function clear() {
+clear_rules() {
RETVAL=0
get_supported_tables
echo -n "Clearing ebtables rulesets: "
@@ -90,7 +90,7 @@ function clear() {
fi
}
-function save() {
+save() {
RETVAL=0
get_supported_tables
echo -n "Saving ebtables rulesets: "
@@ -127,11 +127,11 @@ case "$1" in
;;
stop)
[ "$EBTABLES_SAVE_ON_STOP" = "yes" ] && save
- clear
+ clear_rules
;;
restart|reload|force-reload)
[ "$EBTABLES_SAVE_ON_RESTART" = "yes" ] && save
- clear
+ clear_rules
[ "$EBTABLES_LOAD_ON_START" = "yes" ] && load
;;
load)
--
2.14.3
reply other threads:[~2018-01-12 15:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112150256.24391-1-JPEWhacker@gmail.com \
--to=jpewhacker@gmail.com \
--cc=joe_macdonald@mentor.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox