Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Andrea Adami <andrea.adami@gmail.com>
Cc: paul.eggleton@linux.intel.com,
	Koen Kooi <koen@dominion.thruhere.net>,
	OpenEmbedded Devel List
	<openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-handheld][PATCH] zaurusd: refresh patches (using devtool)
Date: Thu, 12 Apr 2018 21:34:53 -0400	[thread overview]
Message-ID: <20180413013453.GH3228@denix.org> (raw)
In-Reply-To: <CAAQYJAtv_KyDE5YLCVB3n18E9MgkokQ78sAwy0KmTemAd+m7WA@mail.gmail.com>

On Thu, Apr 12, 2018 at 11:23:39AM +0200, Andrea Adami wrote:
> On Thu, Apr 12, 2018 at 10:59 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> > Op 10-04-18 om 23:01 schreef Andrea Adami:
> >> Silence warnings about ingnored context.
> >>
> >> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> >
> >
> >> --- a/recipes-bsp/zaurusd/zaurusd/0001-zaurusd-add-support-for-collie.patch
> >> +++ b/recipes-bsp/zaurusd/zaurusd/0001-zaurusd-add-support-for-collie.patch
> >> @@ -1,17 +1,17 @@
> >> -From 85b94bed1feab70bc529a59fb80c26da825b9abe Mon Sep 17 00:00:00 2001
> >> +From 668a7bc50ca8f36df5a0eae73a5fa251aada9cc4 Mon Sep 17 00:00:00 2001
> >>  From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> >>  Date: Fri, 5 Aug 2011 16:00:10 +0400
> >>  Subject: [PATCH] zaurusd: add support for collie
> >> -Upstream-Status: Pending
> > Was that change intended?
> 
> No, not really.
> Let say I have spotted it and planned to read the devtool code...
> 
> I think it is tolerable in this context, because unfortunately not all
> patches have Upstream-Status.
> (I am wondering if there is still Upstream for zaurusd...)
> 
> So I have left the result unchanged., planning to update the
> Upstream-Status soon.

Related, but not exactly the same:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=12674

Basically, in your case Upstream-status was above the empty line that 
separates patch header and patch description. Upstream-status should be 
in the patch description or it will be lost by devtool...

-- 
Denys


      reply	other threads:[~2018-04-13  1:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 21:01 [meta-handheld][PATCH] zaurusd: refresh patches (using devtool) Andrea Adami
2018-04-12  8:59 ` Koen Kooi
2018-04-12  9:23   ` Andrea Adami
2018-04-13  1:34     ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180413013453.GH3228@denix.org \
    --to=denis@denix.org \
    --cc=andrea.adami@gmail.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox