From: "André Draszik" <git@andred.net>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-java][PATCH] libecj-bootstrap-native: simplify build
Date: Wed, 25 Apr 2018 15:59:49 +0100 [thread overview]
Message-ID: <20180425145949.8524-1-git@andred.net> (raw)
From: André Draszik <andre.draszik@jci.com>
Piping 'find' output into multiple files to re-read
them seems inelegant and is error prone - just use a
pipe with appropriate options instead.
This avoids potential problems with funny file names,
and now also makes use of BB_NUMBER_THREADS to speed
up compilation.
This is a better example to copy from now...
Signed-off-by: André Draszik <andre.draszik@jci.com>
---
recipes-core/ecj/libecj-bootstrap.inc | 25 +++++++------------------
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a/recipes-core/ecj/libecj-bootstrap.inc b/recipes-core/ecj/libecj-bootstrap.inc
index 9350550..04425f4 100644
--- a/recipes-core/ecj/libecj-bootstrap.inc
+++ b/recipes-core/ecj/libecj-bootstrap.inc
@@ -17,13 +17,8 @@ JAR = "ecj-bootstrap-${PV}.jar"
do_unpackpost[dirs] = "${B}"
do_unpackpost() {
- if [ ! -d source ]; then
- mkdir source
- fi
-
- if [ ! -d build ]; then
- mkdir build
- fi
+ mkdir -p source
+ mkdir -p build
# Remove crap.
rm -f about.html build.xml
@@ -44,24 +39,18 @@ do_unpackpost() {
cp -R source/org build/
# Remove source code and other stuff.
- find build -name '*.java' -exec rm -f {} \;
- find build -name '*.html' -exec rm -f {} \;
+ find build -depth \( -name '*.java' -o -name '*.html' \) -delete
}
addtask unpackpost after do_unpack before do_patch
do_compile() {
- find source -name '*.java' | LC_ALL=C sort > sourcefiles
- split -l 25 sourcefiles ecj-sources.
-
# Compiling in place is done because the sources contain
# property files which need to be available at runtime.
- for list in `find . -name 'ecj-sources.*'`; do
- echo "building files in $list ...";
- echo jikes-initial -d build -source 1.4 -sourcepath source `cat $list`;
- jikes-initial \
- -d build -source 1.4 -sourcepath source `cat $list`;
- done
+ find source -name '*.java' -print0 \
+ | LC_ALL=C sort -z \
+ | xargs -0 -n25 -P ${BB_NUMBER_THREADS} \
+ jikes-initial -d build -source 1.4 -sourcepath source
fastjar -c -C build . -f ${JAR}
}
--
2.16.2
next reply other threads:[~2018-04-25 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 14:59 André Draszik [this message]
2018-06-19 7:36 ` [meta-java][PATCH] libecj-bootstrap-native: simplify build Richard Leitner
2018-06-19 8:04 ` Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425145949.8524-1-git@andred.net \
--to=git@andred.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox