From: Kai Kang <kai.kang@windriver.com>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-xfce][PATCH 03/10] xfce4-hotcorner-plugin: fix library install path
Date: Mon, 6 Aug 2018 01:54:01 -0700 [thread overview]
Message-ID: <20180806085408.44739-4-kai.kang@windriver.com> (raw)
In-Reply-To: <20180806085408.44739-1-kai.kang@windriver.com>
The library install path may be ${CMAKE_INSTALL_PREFIX}/lib64 rather
than fixed ${CMAKE_INSTALL_PREFIX}/lib. Add a variable in CMakeLists.txt
to make it could be overrode by cmake command line. And it is overridden
with ${baselib} in meta-oe.
Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
...1-CMakeLists.txt-fix-library-install-path.patch | 39 ++++++++++++++++++++++
.../hotcorner/xfce4-hotcorner-plugin_0.0.2.bb | 5 ++-
2 files changed, 43 insertions(+), 1 deletion(-)
create mode 100644 meta-xfce/recipes-panel-plugins/hotcorner/xfce4-hotcorner-plugin/0001-CMakeLists.txt-fix-library-install-path.patch
diff --git a/meta-xfce/recipes-panel-plugins/hotcorner/xfce4-hotcorner-plugin/0001-CMakeLists.txt-fix-library-install-path.patch b/meta-xfce/recipes-panel-plugins/hotcorner/xfce4-hotcorner-plugin/0001-CMakeLists.txt-fix-library-install-path.patch
new file mode 100644
index 000000000..df348dc85
--- /dev/null
+++ b/meta-xfce/recipes-panel-plugins/hotcorner/xfce4-hotcorner-plugin/0001-CMakeLists.txt-fix-library-install-path.patch
@@ -0,0 +1,39 @@
+Upstream-Status: Submitted [https://github.com/brianhsu/xfce4-hotcorner-plugin/pull/8]
+
+The library install path may be ${CMAKE_INSTALL_PREFIX}/lib64 rather
+than fixed ${CMAKE_INSTALL_PREFIX}/lib. Provide a variable to make it
+could override by cmake command line.
+
+Signed-off-by: Kai Kang <kai.kang@windriver.com>
+---
+ CMakeLists.txt | 7 ++++---
+ 1 file changed, 4 insertions(+), 3 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index e193787..84cb52d 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -10,8 +10,9 @@ include(GNUInstallDirs)
+
+ PKG_CHECK_MODULES(GTK REQUIRED libxfce4panel-1.0 libxfce4ui-1 libwnck-3.0)
+
+-set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
+-set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
++set(BASE_LIB_PATH "lib" CACHE STRING "base library install path")
++set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${BASE_LIB_PATH})
++set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${BASE_LIB_PATH})
+ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
+
+ INCLUDE_DIRECTORIES(${GTK_INCLUDE_DIRS})
+@@ -28,7 +29,7 @@ ADD_LIBRARY(hotcorner SHARED src/hotcorner.c src/util.c)
+
+ TARGET_LINK_LIBRARIES(hotcorner ${GTK_LIBRARIES})
+
+-INSTALL(TARGETS hotcorner LIBRARY DESTINATION lib/xfce4/panel/plugins/)
++INSTALL(TARGETS hotcorner LIBRARY DESTINATION ${BASE_LIB_PATH}/xfce4/panel/plugins/)
+ INSTALL(FILES hotcorner.desktop DESTINATION share/xfce4/panel/plugins/)
+ GETTEXT_CREATE_TRANSLATIONS(po/xfce4-hotcorner-plugin.pot ALL po/zh_TW.po)
+
+--
+2.11.0
+
diff --git a/meta-xfce/recipes-panel-plugins/hotcorner/xfce4-hotcorner-plugin_0.0.2.bb b/meta-xfce/recipes-panel-plugins/hotcorner/xfce4-hotcorner-plugin_0.0.2.bb
index f86c92ed2..57a815b1b 100644
--- a/meta-xfce/recipes-panel-plugins/hotcorner/xfce4-hotcorner-plugin_0.0.2.bb
+++ b/meta-xfce/recipes-panel-plugins/hotcorner/xfce4-hotcorner-plugin_0.0.2.bb
@@ -6,6 +6,9 @@ inherit xfce-panel-plugin cmake
DEPENDS += "libwnck3"
-SRC_URI = "https://github.com/brianhsu/${BPN}/releases/download/${PV}/${BPN}-${PV}.tar.gz"
+SRC_URI = "https://github.com/brianhsu/${BPN}/releases/download/${PV}/${BPN}-${PV}.tar.gz \
+ file://0001-CMakeLists.txt-fix-library-install-path.patch"
SRC_URI[md5sum] = "ac31b45cda1867cb6bd69bb285638263"
SRC_URI[sha256sum] = "942684c92f96a158e1417e597947f822769ac56aa1993a8c9f166ee633ef2b8d"
+
+EXTRA_OECMAKE = "-DBASE_LIB_PATH=${baselib}"
--
2.11.0
next prev parent reply other threads:[~2018-08-06 8:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 8:53 [meta-xfce][PATCH 00/10] Upgrade packages in layer meta-xfce Kai Kang
2018-08-06 8:53 ` [meta-xfce][PATCH 01/10] libwnck3: 3.20.1 -> 3.24.1 Kai Kang
2018-08-06 9:02 ` [meta-gnome][PATCH " Kang Kai
2018-08-06 8:54 ` [meta-xfce][PATCH 02/10] xfce4-mount-plugin: 1.1.2 -> 1.1.3 Kai Kang
2018-08-06 8:54 ` Kai Kang [this message]
2018-08-06 8:54 ` [meta-xfce][PATCH 04/10] xfce4-embed-plugin: 1.0.0 -> 1.6.0 Kai Kang
2018-08-06 17:31 ` Khem Raj
2018-08-07 2:00 ` Kang Kai
2018-08-07 2:17 ` [PATCH V2] " Kai Kang
2018-08-06 8:54 ` [meta-xfce][PATCH 05/10] xfce4-eyes-plugin: 4.4.5 -> 4.5.0 Kai Kang
2018-08-06 8:54 ` [meta-xfce][PATCH 06/10] xfce4-genmon-plugin: 4.0.0 -> 4.0.1 Kai Kang
2018-08-06 8:54 ` [meta-xfce][PATCH 07/10] exo: 0.12.1 -> 0.12.2 Kai Kang
2018-08-06 8:54 ` [meta-xfce][PATCH 08/10] xfce4-session: 4.12.1 -> 4.13.0 Kai Kang
2018-08-06 8:54 ` [meta-xfce][PATCH 09/10] xfconf: 4.13.4 -> 4.13.5 Kai Kang
2018-08-06 8:54 ` [meta-xfce][PATCH 10/10] xfwm4: 4.12.4 -> 4.12.5 Kai Kang
2018-08-08 10:00 ` [meta-xfce][PATCH 00/10] Upgrade packages in layer meta-xfce Andreas Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806085408.44739-4-kai.kang@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox