From: "André Draszik" <git@andred.net>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-java][PATCH 7/9] Revert "openjdk-8: fix build for gcc8.x"
Date: Mon, 13 Aug 2018 11:09:34 +0100 [thread overview]
Message-ID: <20180813100936.23663-8-git@andred.net> (raw)
In-Reply-To: <20180813100936.23663-1-git@andred.net>
From: André Draszik <andre.draszik@jci.com>
This reverts commit 52fb41cec7d5125bb11c718705158696ffef11f8.
The change being reverted has two problems:
- it still doesn't produce working binaries
- compilation on pre-gcc v7 compilers fails (which is
relevant for compiling openjdk-8-native, as that
uses the build machine's gcc, not yocto's gcc):
| At global scope:
| cc1plus: error: unrecognized command line option ‘-Wno-stringop-overflow’ [-Werror]
| cc1plus: all warnings being treated as errors
We now use a different approach to address the issues
than that patch, and it is thusly not needed anymore.
We fully support gcc < 7 again.
Signed-off-by: André Draszik <andre.draszik@jci.com>
---
.../openjdk/openjdk-8-release-16xbyy.inc | 1 -
.../hotspot_fix_gcc8x_build.patch | 21 -------------------
2 files changed, 22 deletions(-)
delete mode 100644 recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch
diff --git a/recipes-core/openjdk/openjdk-8-release-16xbyy.inc b/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
index bd440c6..8b30c37 100644
--- a/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
+++ b/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
@@ -16,7 +16,6 @@ PATCHES_URI = "\
file://0008-jdk-use-correct-include-for-signal.patch \
file://0009-jdk-disable-backtrace-musl-build-fix.patch \
file://0010-build-fix-build-on-as-needed-toolchains-generic.patch \
- file://hotspot_fix_gcc8x_build.patch \
file://0011-hotspot-backport-patch-to-fix-misuses-of-strncpy-str.patch \
"
# some patches extracted from http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/webrev.01/hotspot.patch
diff --git a/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch b/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch
deleted file mode 100644
index 1a406f2..0000000
--- a/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch
+++ /dev/null
@@ -1,21 +0,0 @@
-From: Richard Leitner <richard.leitner@skidata.com>
-Date: Thu, 14 Jun 2018 23:42:11 +0200
-Subject: [PATCH] openjdk-8: hotspot: fix gcc8 compilation
-
-As oe-core/yocto-project master migrated to gcc8.x we need to support this.
-Therefore disable following gcc warnings/errors which caused the build to fail:
- + stringop-overflow
- + return-type
----
-
---- a/hotspot/make/linux/makefiles/gcc.make
-+++ b/hotspot/make/linux/makefiles/gcc.make
-@@ -197,7 +197,7 @@
- endif
-
- # Compiler warnings are treated as errors
--WARNINGS_ARE_ERRORS = -Werror
-+WARNINGS_ARE_ERRORS = -Werror -Wno-stringop-overflow -Wno-error=return-type
-
- ifeq ($(USE_CLANG), true)
- # However we need to clean the code up before we can unrestrictedly enable this option with Clang
--
2.18.0
next prev parent reply other threads:[~2018-08-13 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 10:09 [meta-java] OpenJDK-8 fixes and updates André Draszik
2018-08-13 10:09 ` [meta-java][PATCH 1/9] gitignore: ignore new python byte-code files André Draszik
2018-08-13 10:09 ` [meta-java][PATCH 2/9] openjdk-8: speed-up do_install() (pack200) André Draszik
2018-08-13 10:09 ` [meta-java][PATCH 3/9] openjdk-8: remove superfluous compiler flag (-std=gnu++98) André Draszik
2018-08-13 10:09 ` [meta-java][PATCH 4/9] openjdk-8: fix infrastructure for version host gcc != cross gcc (again) André Draszik
2018-08-13 13:53 ` Richard Leitner
2018-08-13 10:09 ` [meta-java][PATCH 5/9] openjdk-8: gcc-8 fix #1: backport patch to fix misuses of strncpy/strncat André Draszik
2018-08-13 10:09 ` [meta-java][PATCH 6/9] openjdk-8: gcc-8 fix #2: silence build warnings/errors (return-type) André Draszik
2018-08-13 13:03 ` Richard Leitner
2018-08-13 14:25 ` André Draszik
2018-08-13 10:09 ` André Draszik [this message]
2018-08-13 10:09 ` [meta-java][PATCH 8/9] openjdk-8: gcc-8 fix #3: working binaries André Draszik
2018-08-13 10:09 ` [meta-java][PATCH 9/9] openjdk-8: update to 8u172b11 André Draszik
2018-08-13 10:41 ` [meta-java] OpenJDK-8 fixes and updates Richard Leitner
2018-08-13 14:53 ` Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813100936.23663-8-git@andred.net \
--to=git@andred.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox