From: "S. Lockwood-Childs" <sjl@vctlabs.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
Date: Fri, 28 Sep 2018 13:14:54 -0700 [thread overview]
Message-ID: <20180928201454.GW594@vctlabs.com> (raw)
In-Reply-To: <20180927140251.4556-1-Martin.Jansa@gmail.com>
Could you explain commit 0db9697dc6b8c a little bit, where libpam became a
distro requirement for samba itself? I'm not sure why pam is a hard
requirement, rather than being PACKAGECONFIG option. I haven't tried the server
ipk built with --without-pam but the client-side pieces are certainly useful.
I've got a bbappend to override the pam forcing, and was just wondering if
this change might be upstreamable.
On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
> * dependency on samba was added recently in:
> libldb: Add samba to rdeps for pyldb
> so now we need to match samba restriction to prevent:
>
> ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it)
> samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
> NOTE: Runtime target 'samba' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['samba']
> ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> index 99e62f66bb..3c7e5455e9 100644
> --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
> SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
> SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
>
> -inherit waf-samba
> +inherit waf-samba distro_features_check
> +REQUIRED_DISTRO_FEATURES = "pam"
>
> S = "${WORKDIR}/ldb-${PV}"
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2018-09-28 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 14:02 [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES Martin Jansa
2018-09-28 20:14 ` S. Lockwood-Childs [this message]
2018-09-28 20:23 ` Khem Raj
2018-09-28 21:08 ` S. Lockwood-Childs
2018-09-29 7:45 ` Martin Jansa
2018-10-01 10:26 ` Peter Kjellerstedt
2018-10-01 10:32 ` Martin Jansa
2018-10-10 6:18 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928201454.GW594@vctlabs.com \
--to=sjl@vctlabs.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox