Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Randy MacLeod <Randy.MacLeod@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: [PATCH 2/2] libvncserver: make PACKAGECONFIG flags explicit
Date: Mon, 28 Jan 2019 13:24:01 -0500	[thread overview]
Message-ID: <20190128182401.8932-2-Randy.MacLeod@windriver.com> (raw)
In-Reply-To: <20190128182401.8932-1-Randy.MacLeod@windriver.com>

Set all the PACKAGECONFIG enable/disable flags explicitly
rather than rely on assumed defaults. This also makes it
clear what the intended configuration is in log files.

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 .../libvncserver/libvncserver_git.bb           | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb b/meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb
index 627b03109..88a859ba2 100644
--- a/meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb
+++ b/meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb
@@ -15,15 +15,15 @@ PACKAGECONFIG ??= " \
     sdl \
     zlib \
 "
-PACKAGECONFIG[gcrypt] = ",,libgcrypt,libgcrypt"
-PACKAGECONFIG[gnutls] = ",,gnutls"
-PACKAGECONFIG[jpeg] = ",-DWITH_JPEG=OFF,jpeg"
-PACKAGECONFIG[lzo] = ",-DWITH_LZO=OFF,lzo"
-PACKAGECONFIG[openssl] = ",-DWITH_OPENSSL=OFF,openssl"
-PACKAGECONFIG[png] = ",-DWITH_PNG=OFF,libpng,libpng"
-PACKAGECONFIG[systemd] = ",,systemd"
-PACKAGECONFIG[sdl] = ",,libsdl2"
-PACKAGECONFIG[zlib] = ",,zlib"
+PACKAGECONFIG[gcrypt] = "-DWITH_GCRYPT=ON,-DWITH_GCRYPT=OFF,libgcrypt,libgcrypt"
+PACKAGECONFIG[gnutls] = "-DWITH_GNUTLS=ON,-DWITH_GNUTLS=OFF,gnutls"
+PACKAGECONFIG[jpeg] = "-DWITH_JPEG=ON,-DWITH_JPEG=OFF,jpeg"
+PACKAGECONFIG[lzo] = "-DWITH_LZO=ON,-DWITH_LZO=OFF,lzo"
+PACKAGECONFIG[openssl] = "-DWITH_OPENSSL=ON,-DWITH_OPENSSL=OFF,openssl"
+PACKAGECONFIG[png] = "-DWITH_PNG=ON,-DWITH_PNG=OFF,libpng,libpng"
+PACKAGECONFIG[systemd] = "-DWITH_SYSTEMD=ON,-DWITH_SYSTEMD=OFF,systemd"
+PACKAGECONFIG[sdl] = "-DWITH_SDL=ON,-DWITH_SDL=OFF,libsdl2"
+PACKAGECONFIG[zlib] = "-DWITH_ZLIB=ON,-DWITH_ZLIB=OFF,zlib"
 
 inherit cmake
 
-- 
2.17.0



      reply	other threads:[~2019-01-28 18:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 18:24 [PATCH 1/2] libvncserver: Update to latest commit post 0.9.12 Randy MacLeod
2019-01-28 18:24 ` Randy MacLeod [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190128182401.8932-2-Randy.MacLeod@windriver.com \
    --to=randy.macleod@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox