Re: [meta-oe][PATCH] asio: add PACKAGECONFIG boost

[Adrian Bunk <bunk@stusta.de>]

On Thu, Mar 07, 2019 at 10:03:08AM +0100, Sean Nyekjaer wrote:
> 
> 
> On 07/03/2019 09.53, Adrian Bunk wrote:
> > On Thu, Mar 07, 2019 at 09:29:17AM +0100, Sean Nyekjaer wrote:
> > > Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> > > ---
> > >   meta-oe/recipes-support/asio/asio_1.12.2.bb | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/meta-oe/recipes-support/asio/asio_1.12.2.bb b/meta-oe/recipes-support/asio/asio_1.12.2.bb
> > > index ee548fd3a..ec705c275 100644
> > > --- a/meta-oe/recipes-support/asio/asio_1.12.2.bb
> > > +++ b/meta-oe/recipes-support/asio/asio_1.12.2.bb
> > > @@ -20,3 +20,7 @@ SRC_URI[md5sum] = "312e53385e2daad10f08d57f91ad3431"
> > >   SRC_URI[sha256sum] = "4e27dcb37456ba707570334b91f4798721111ed67b69915685eac141895779aa"
> > >   SRC_URI = "${SOURCEFORGE_MIRROR}/asio/${BP}.tar.bz2"
> > > +
> > > +PACKAGECONFIG ??= "boost"
> > > +
> > > +PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
> > 
> > Adding an RDEPENDS in the PACKAGECONFIG looks wrong.
> > boost should also be removed from the DEPENDS above when it is disabled.
> > 
> > This would be on top of your patch:
> > -DEPENDS = "boost openssl"
> > +DEPENDS = "openssl"
> > -PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
> > +PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost"
> > 
> > 
> Hi Adrian,
> 
> I missed the DEPENDS, thanks :-)
> But why does the extra RDEPENDS looks wrong?

It forces all boost libraries to be installed on the target,
no matter whether or not they are used.

> I'll send a PATCHv2
> 
> /Sean

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed