Re: [meta-networking][PATCH] networkmanager: goodbye libnm-glib

[Adrian Bunk <bunk@stusta.de>]

On Fri, Jun 28, 2019 at 10:57:02PM +0800, Hongxu Jia wrote:
> On 6/28/19 6:07 PM, Adrian Bunk wrote:
> > On Thu, Jun 27, 2019 at 09:47:49AM -0400, Hongxu Jia wrote:
> > > Since commit [061953143 networkmanager: Update to 1.18.0] applied,
> > > upstream disable libnm-glib by default. And in further networkmanager,
> > > upstream removes libnm-glib, libnm-glib-vpn, and libnm-util for good
> > > ...
> > Any strong reason for removing this already now?
> 
> Make sure to clean up empty package, in 1.18
> 
> libnm-glib is already disabled, and left three empty
> 
> packages(no package generated acturally). I found
> 
> the issue, trace the reason and provide fix

What problem does this issue cause?

> You may note original PACKAGECONFIG[glib] does not have
> 
> without option, so clean up it rather than add missing without option
> 
> PACKAGECONFIG[glib] = "--with-libnm-glib,,dbus-glib-native dbus-glib"

That is actually fine and doesn't need a fix - the library is only built 
if explicitely requested --with-libnm-glib.

> > It's gone in 1.20 so removal then is clear, but if someone wants
> > to use it for legacy code with 1.18 this should stay possible as
> > long as <= 1.18 is shipped.
> 
> I think it will be upgraded 1.20 soon, and if someone wants
> 
> to use legacy code, I think 1.16 in warrior is better choose
> 
> which libnm-glib is always enabled

"soon" might be after Yocto 2.8 branches.

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed